Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some strange behavior I saw around bootstrap 5 styling.
Fixes
Case 1: Border Highlight
If the classes
form-select
orform-control
were applied to the wrapper, then the highlight box around the select would be slightly thinner than should be.The issue was not present if
form-select
orform-control
were not provided.Case 2
When
form-select
andform-control
are omitted the border only changes color when clicked, and no icon is present.Case 3
When
form-select
andform-control
are present, the highlight box does not appear when focusedBroken?
My changes are not perfect, as for example:
form-select
orform-control
, you won't see the iconI don't use sass very often, so open to improvements, but figured I'd give it a first shot. Let me know what you think!