Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap5 sass #763

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nblum-mdmi
Copy link

This PR addresses some strange behavior I saw around bootstrap 5 styling.

Fixes

Case 1: Border Highlight

If the classes form-select or form-control were applied to the wrapper, then the highlight box around the select would be slightly thinner than should be.

image

image

The issue was not present if form-select or form-control were not provided.

Case 2

When form-select and form-control are omitted the border only changes color when clicked, and no icon is present.

image
image

image
image

Case 3

When form-select and form-control are present, the highlight box does not appear when focused

image

image

Broken?

My changes are not perfect, as for example:

  • When you have a validity class but no form-select or form-control, you won't see the icon

image
image

image
image

I don't use sass very often, so open to improvements, but figured I'd give it a first shot. Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant