fix: remove deprecated overflow-y:overlay in .pm__body#821
Open
terminalchai wants to merge 1 commit intoorestbida:masterfrom
Open
fix: remove deprecated overflow-y:overlay in .pm__body#821terminalchai wants to merge 1 commit intoorestbida:masterfrom
terminalchai wants to merge 1 commit intoorestbida:masterfrom
Conversation
|
@krishhmaaya-innovations is attempting to deploy a commit to the Orest Bida's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for cookieconsentv3-playground canceled.
|
terminalchai
force-pushed
the
fix/remove-deprecated-overflow-overlay
branch
2 times, most recently
from
87c8e03 to
1b44fbf
Compare
The overlay value is non-standard and was removed in Chrome 112+. The overflow-y: auto declaration above it handles scrolling correctly. Fixes orestbida#784
terminalchai
force-pushed
the
fix/remove-deprecated-overflow-overlay
branch
from
1b44fbf to
6435475
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #784
The .pm__body element has two overflow-y declarations:
\\css
overflow-y: auto;
overflow-y: overlay; /* deprecated — removed in Chrome 112+ */
\\
overflow-y: overlay is a non-standard WebKit value that was deprecated and removed in Chrome 112. Modern browsers log a deprecation warning for this property.
Fix
Remove the overflow-y: overlay line. The overflow-y: auto declaration directly above it already handles scrolling correctly on all browsers.
Changes
Testing
All 119 existing tests pass (9/9 suites).