chore: make sure to use parameters in logging

orientechnologies · Sep 30, 2024 · 5f10539 · 5f10539
1 parent 9899907
commit 5f10539
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/driver/src/main/java/org/apache/tinkerpop/gremlin/orientdb/OrientGraph.java b/driver/src/main/java/org/apache/tinkerpop/gremlin/orientdb/OrientGraph.java
@@ -595,7 +595,7 @@ public void close() {
           }
         }
       } catch (Exception e) {
-        logger.error("Error during context close for db " + url, e);
+        logger.error("Error during context close for db %s", e, url);
       }
     }
   }
@@ -649,7 +649,7 @@ public void createClass(final String className, final OClass superClass) {
       } catch (OException e) {
         throw new IllegalArgumentException(e);
       }
-      logger.info("created class '" + className + "' as subclass of '" + superClass + "'");
+      logger.info("created class '%s' as subclass of '%s'", className, className);
     } else {
       if (!cls.isSubClassOf(superClass)) {
         throw new IllegalArgumentException(
@@ -754,7 +754,7 @@ public <RET> RET execute(
       for (String s : iOperationStrings) msg.append(s);
 
       // ASSURE PENDING TX IF ANY IS COMMITTED
-      logger.warn(msg.toString());
+      logger.warn("%s", msg.toString());
     }
     return iCallable.call(this);
   }

diff --git a/...java/org/apache/tinkerpop/gremlin/orientdb/traversal/step/sideeffect/OrientGraphStep.java b/...java/org/apache/tinkerpop/gremlin/orientdb/traversal/step/sideeffect/OrientGraphStep.java
@@ -205,8 +205,7 @@ public Set<OrientIndexQuery> findIndex() {
                         // TODO: select best index if there are multiple options
                         indexedQueries.add(new OrientIndexQuery(keyIndexes.next(), values));
                       } else {
-                        logger.warn(
-                            "no index found for class=[" + className + "] and key=[" + key + "]");
+                        logger.warn("no index found for class=[%s] and key=[%s]", className, key);
                       }
                     });
               });