refactor(MigrateDumpCommand::sqliteDump): Simply slightly.

orisintel · Apr 5, 2019 · 7438b0d · 7438b0d
1 parent eeefcec
commit 7438b0d
Showing 1 changed file with 3 additions and 14 deletions.
diff --git a/src/Commands/MigrateDumpCommand.php b/src/Commands/MigrateDumpCommand.php
@@ -174,13 +174,11 @@ private static function sqliteDump(array $db_config, string $schema_sql_path) :
         $tables = preg_split('/\s+/', implode(' ', $output));
 
         foreach ($tables as $table) {
-            // Migrations to be dumped with data afterward.
-            if ('migrations' === $table) {
-                continue;
-            }
+            // Only migrations should dump data with schema.
+            $sql_command = 'migrations' === $table ? '.dump' : '.schema';
 
             passthru(
-                $command_prefix . ' ' . escapeshellarg(".schema $table")
+                $command_prefix . ' ' . escapeshellarg("$sql_command $table")
                 . ' >> ' . escapeshellarg($schema_sql_path),
                 $exit_code
             );
@@ -189,15 +187,6 @@ private static function sqliteDump(array $db_config, string $schema_sql_path) :
             }
         }
 
-        passthru(
-            $command_prefix . ' ' . escapeshellarg(".dump migrations")
-            . ' >> ' . escapeshellarg($schema_sql_path),
-            $exit_code
-        );
-        if (0 !== $exit_code) {
-            return $exit_code;
-        }
-
         return $exit_code;
     }
 }