Avoid illegal reflective access when possible #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test passes on Java 8, but yields warning on 9+ and exception on 16+. It's essentially the same as orphan-oss#104 . OGNL should call `StringBuilder#codePointAt()` (which is a bridge method) rather than the method defined in its non-public parent class `AbstractStringBuilder`.
The test passes on Java 8, but yields warning on 9+ and exception on 16+.
The test passes on Java 8, but yields warning on 9+ and exception on 16+.
The test passes, but there is a message in System.err: Two methods with same method signature but not providing classes assignable? This was originally reported as orphan-oss#35 and temporarily resolved by orphan-oss#40 , but as you can see, this is not an error case in the first place.
The test passes, but there is a message in System.err. It might have been a legitimate check in non-generic era, but not anymore.
The test passes, but there is a message in System.err. Slightly different version of the previous commit.
|
OGNL 3.3.2 is out! Thanks a lot! |
|
Thank you for the swift response, @lukaszlenart ! |
|
I'm sorry to bother you, but I forgot to remove the unused local variable |
|
Please issue a PR, thank you :) |
harawata
added a commit
to harawata/ognl
that referenced
this pull request
Jan 10, 2022
This is a follow-up to orphan-oss#144 orphan-oss#144 (comment)
This was referenced Jan 10, 2022
harawata
added a commit
to harawata/ognl
that referenced
this pull request
Jul 9, 2022
This may be a side effect of orphan-oss#144 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #143 , making a method accessible is problematic in recent versions of Java ('illegal reflective access' warning on 9+ and InaccessibleObjectException on 16+).
This PR avoids some illegal reflective accesses that I found.
Please see the log message of each commit for the details.