When scanning super interfaces in OgnlRuntime#getMethods(Class, bool…

[harawata]

…ean), only default methods should be collected instead of all declared methods. This should fix #35 .

Also, it now searches super interfaces recursively to handle deeper interface hierarchy as follows.

interface InterfaceWithDefaults {
  default public void defaultMethod() { }
}

interface SubInterfaceWithDefaults extends InterfaceWithDefaults {
}

class ClassWithDefaults implements SubInterfaceWithDefaults {
}

@Test
public void testDefaultMethodOnClass() {
  List result = OgnlRuntime.getMethods(
    ClassWithDefaults.class, "defaultMethod", false);
  assertNotNull(defaultMethod);
}

To achieve the recursive search, I extracted some methods. Was it OK ?
I ask because the original code seemed to avoid it intentionally for some reason.

A few not-directly-related things I noticed:

• PR fix for issue #29 - Ognl.GetMethods does not return default methods from interfaces implemented by parent class #30 was not applied to getAllMethods(Class, boolean).
  EDIT: getAllMethods() uses Class#getMethods() and returns superinterfaces' default methods correctly.
• PR Add access for property which read method is java8 default method #33 does not search interfaces recursively.

If this PR is acceptable, I will send another PR to backport the change to 3.1 (and 3.0 if it's appropriate).

[lukaszlenart]

Looks good to me ... give me some time to take another shot (just returned from vacations ;-)

[harawata]

Hope you recharged your batteries! =)
Please take your time. I'm not surprised if I missed something.

[lukaszlenart]

@harawata could you resolve that conflict? Or you can target 3.1.x

[harawata]

@lukaszlenart Done!
I'll open another PR for 3.1.x.

Thanks!

[lukaszlenart]

LGTM 💯 & thank you again :)