getDeclaredMethods() should search super-interfaces recursively.

[harawata]

This should fix #51 .

A few comments:

• While the original code instantiated the ArrayList lazily, this PR instantiates it before starting the scan (because it's simpler). I think it's acceptable, but please let me know if it isn't.
• There may be a room for further refactoring (collectMethods() and collectAccessors()), but it requires a bigger change.
• Is there any guideline for the code format? XD

[YSavanier]

Thank you very much I will test your code first thing tomorrow morning 😊

[YSavanier]

Thank you I've checked and your implementation is even better than the former one since it also get default methods of interface herited from super interfaces !!!
I look forward seeing this added to the 3.1.x branch :)

PS : BTW in your fork I noted some code not in the PR in method getReadMethod on line 2950 you replaced

        BeanInfo info = Introspector.getBeanInfo(target);
        MethodDescriptor[] methods = info.getMethodDescriptors();

by :

        Method[] methods = target.getMethods();

Is it to overcome a potential bug in Introspector since the code seems to handle just fine with your last PR ?

B.R.

[harawata]

Thank you for testing, @YSavanier !

I'm not sure which PR you are referring to, but it would be #33 that replaced Introspector (not my PR).
This is my third PR and I have not modified getReadMethods() so far.

• https://github.com/jkuhnert/ognl/pull/40/files
• https://github.com/jkuhnert/ognl/pull/41/files
• https://github.com/jkuhnert/ognl/pull/55/files

[lukaszlenart]

Ok, I think we are good to merge this PR? Any objections?

[YSavanier]

I'm looking forward to it being released ^^

[lukaszlenart]

LGTM 👍

[lukaszlenart]

@harawata do you plan to cherry-pick those changes to 3.1.x branch?

[lukaszlenart]

3.2.7 is under way to the Central :) Thanks a lot!

[harawata]

Thanks for the merge and the quick release, @lukaszlenart !
I'll open another PR for the 3.1.x port tonight.

[lukaszlenart]

Cool, thanks a lot for your support :)