DefaultClassResolver should resolve classes in the default package #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultClassResolver#classForName()throwsClassNotFoundExceptionif the specified class is in the default package (i.e. no dot in the className).Using the default package should be avoided, but we have received a few bug reports about it.
mybatis/mybatis-3#1524
mybatis/mybatis-3#1768
And the reporters said that it was working fine with the older versions, so it probably is related to #46 .
To write a test, I had to create a class in the default package.
If you don't like it, I will remove the class along with the test.
The comment in the source might be good enough to avoid regression.