WW-5043 Enum comparison failure fix #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve OgnlOps.compareWithConversion() to handle special case of enumerated types (Enum) with element bodies. - Add additional equality and inequality unit tests for enumerated types.
|
Hello OGNL Team. This PR is an attempt to address the issue raised in WW-5043. The actual change is small code-wise and I did not see any risk in adding it ... but if anyone sees a risk/flaw please let me know. For relevant discussion on enumerated type checking see (https://stackoverflow.com/questions/4166488/checking-if-a-class-is-java-lang-enum). Trying to figure out why the edge case was failing and getting unit tests set up took more time than the actual code changes. 😓 If the solution looks OK for OGNL 3.1.x it can easily be cherry-picked into 3.2.x. |
|
Looks good, LGTM 👍 I will prepare new releases as soon as this change will be cherry-picked into 3.2.x, thanks! |
|
w00t! This wasn't merged??? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WW-5043 Enum comparison failure fix: