Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add desktop support to flutter example #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Corbie-42
Copy link

Add build targets Linux, macOS and Windows.

This was done by executing:

flutter create --platforms=windows,macos,linux --project-name ory_network_flutter flutter-ory-network

and adjusting the clientId of the GoogleSignIn in main.dart, so that it is (currently) disabled on desktop.

Add build targets Linux, macOS and Windows.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Corbie-42 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Corbie-42
Copy link
Author

Corbie-42 commented Jan 18, 2024

Okay, I see that you

  1. expect the conventional commits to have an unconventional list of commit titles as body
  2. expect the copyright year to be updated on the first PR on master
  3. require the CLA to be singed. I don't want my email address to be linked to this account, so I won't sign the CLA. Feel free to reproduce the steps or take over this PR.

@vinckr vinckr changed the title Add desktop support to flutter example feat: add desktop support to flutter example Jan 18, 2024
@vinckr
Copy link
Member

vinckr commented Jan 18, 2024

Hello @Corbie-42
Thanks for your contribution!
I will see to bring the repo in order soon. Should be a week or two until I find time to take a closer look at this.

The commits check just failed because it expects a conventional commit PR title, fixed it.

As for the CLA there is unfortunately no way around signing it as we might want to use your contribution in our documentation etc.

Copy link
Contributor

@sashatalalasha sashatalalasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app on macos can't store a session token, it gets immediately deleted after write. This is a flutter_secure_storage package issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants