Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing clocking frequency label to Frequency (Hz) #279

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

shivaahir158
Copy link
Collaborator

@shivaahir158 shivaahir158 commented Nov 27, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details -

@MustafaAbdaal, as discussed -

image

image

What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

  • Frontend: ClockingModal.js. ClockingTable.js
  • Backend:
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests
  • Continuous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break backward-compatibility. If so, please list who may be influenced.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.78%. Comparing base (92c4996) to head (e0b0e5c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   68.78%   68.78%           
=======================================
  Files         110      110           
  Lines        9035     9035           
  Branches      402      402           
=======================================
  Hits         6215     6215           
  Misses       2820     2820           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivaahir158 shivaahir158 marked this pull request as ready for review November 27, 2024 10:00
@shivaahir158 shivaahir158 self-assigned this Nov 27, 2024
Copy link
Collaborator

@MustafaAbdaal MustafaAbdaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clocking Frequency label has been modified as requested. Approved.

@MustafaAbdaal MustafaAbdaal merged commit f37bb87 into main Nov 27, 2024
11 checks passed
@MustafaAbdaal MustafaAbdaal deleted the clocking-freq-hz branch November 27, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants