Compute normal_form with mpolys#257
Draft
SoongNoonien wants to merge 1 commit intooscar-system:masterfrom
Draft
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #257 +/- ##
==========================================
- Coverage 95.96% 95.37% -0.59%
==========================================
Files 12 12
Lines 843 844 +1
==========================================
- Hits 809 805 -4
- Misses 34 39 +5 ☔ View full report in Codecov by Sentry. |
Member
|
Before: After: So it is not much but there. Undraft and merge? We can add more improvements later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As proposed in #250 I tried to perform some computations with mpolys. This is the result when the
normal_formcomputation is done with mpolys instead of upolys.With current master (example from PR #238):
With this PR: