Skip to content

Commit

Permalink
Add a single ci job per group with depwarn=error (#2956)
Browse files Browse the repository at this point in the history
  • Loading branch information
lgoettgens authored Oct 27, 2023
1 parent 821055d commit 8a53dde
Showing 1 changed file with 22 additions and 7 deletions.
29 changes: 22 additions & 7 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,17 @@ jobs:
group: [ 'short', 'long' ]
os:
- ubuntu-latest
depwarn: [ '' ]
include:
# Add a single job per group with deprecation errors on the most recent stable julia version
- julia-version: '1.9'
os: ubuntu-latest
group: 'short'
depwarn: 'depwarn=error'
- julia-version: '1.9'
os: ubuntu-latest
group: 'long'
depwarn: 'depwarn=error'
# Add a few macOS jobs (not too many, the number we can run in parallel is limited)
- julia-version: 'nightly'
os: macOS-latest
Expand Down Expand Up @@ -58,14 +68,14 @@ jobs:
with:
annotate: ${{ matrix.julia-version == '1.9' }}
coverage: ${{ matrix.julia-version == '1.9' }}
depwarn: error
depwarn: ${{ matrix.depwarn == 'depwarn=error' && 'error' || 'no' }}
- name: "Process code coverage"
if: matrix.julia-version == '1.9'
if: matrix.julia-version == '1.9' && matrix.depwarn != 'depwarn=error'
uses: julia-actions/julia-processcoverage@v1
with:
directories: src,experimental
- name: "Upload coverage data to Codecov"
if: matrix.julia-version == '1.9'
if: matrix.julia-version == '1.9' && matrix.depwarn != 'depwarn=error'
continue-on-error: true
uses: codecov/codecov-action@v3

Expand All @@ -81,7 +91,12 @@ jobs:
- 'nightly'
os:
- ubuntu-latest
depwarn: [ '' ]
include:
# Add a single job with deprecation errors on the most recent stable julia version
- julia-version: '1.9'
os: ubuntu-latest
depwarn: 'depwarn=error'
# Add macOS jobs (not too many, the number we can run in parallel is limited)
- julia-version: '1.9'
os: macOS-latest
Expand Down Expand Up @@ -110,7 +125,7 @@ jobs:
with:
annotate: ${{ matrix.julia-version == '1.9' }}
coverage: ${{ matrix.julia-version == '1.9' }}
depwarn: error
depwarn: ${{ matrix.depwarn == 'depwarn=error' && 'error' || 'no' }}
- name: "Setup package"
run: |
julia --project=docs --color=yes -e '
Expand All @@ -120,18 +135,18 @@ jobs:
- name: "Run doctests"
run: |
julia ${{ matrix.julia-version == '1.9' && '--code-coverage' || '' }} \
--project=docs --depwarn=error --color=yes -e'
--project=docs --depwarn=${{ matrix.depwarn == 'depwarn=error' && 'error' || 'no' }} --color=yes -e'
using Documenter
include("docs/documenter_helpers.jl")
using Oscar
DocMeta.setdocmeta!(Oscar, :DocTestSetup, Oscar.doctestsetup(); recursive = true)
doctest(Oscar)'
- name: "Process code coverage"
if: matrix.julia-version == '1.9'
if: matrix.julia-version == '1.9' && matrix.depwarn != 'depwarn=error'
uses: julia-actions/julia-processcoverage@v1
with:
directories: src,experimental
- name: "Upload coverage data to Codecov"
if: matrix.julia-version == '1.9'
if: matrix.julia-version == '1.9' && matrix.depwarn != 'depwarn=error'
continue-on-error: true
uses: codecov/codecov-action@v3

0 comments on commit 8a53dde

Please sign in to comment.