Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary decomposition rerouting #3091

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove TODO.
  • Loading branch information
HechtiDerLachs committed Dec 13, 2023
commit 8b83a77c2e17b447aa131bc1c3846d0a6079d311
3 changes: 0 additions & 3 deletions src/Rings/primary_decomposition_helpers.jl
Original file line number Diff line number Diff line change
@@ -17,9 +17,6 @@
# Since these need the declaration of MPolyQuoRing, they have to come later here
# in an extra file.

# TODO: So far this only concerns towers of simple number fields.
# In the long run we wish to also incorporate number fields of type
# `NFAbsNSElem` and of type `NfNSGen`.
function _expand_coefficient_field(R::MPolyRing{T}; rec_depth::Int=0) where {T<:QQFieldElem}
return R, identity_map(R), identity_map(R)
end