Skip to content

Print a useful complaint instead of garbage #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaruni96 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Print a useful complaint instead of garbage #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion release-notes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,11 @@ def body_to_release_notes(pr):
## not found
## complain and return fallback
print(f"Release notes section not found in PR number {pr['number']}!!")
return body
return (
f"PR number {pr['number']} appears not to have a release notes section! Please check"
"that the body containes a second level heading (starting with `##`) named `Release "
"notes`, and have the entries as lists."
)
index2 = body.find('\n', index1) + 1 # the first line after the release notes line
bodylines = body[index2:].splitlines()
mdstring = ""
Expand Down