Skip to content

refactor: send KEYCODE_ENTER instead of commit "\n" when pressing enter on virtual keyboard #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WhiredPlanck merged 1 commit into from
Mar 7, 2026
+6 −7
Merged

refactor: send KEYCODE_ENTER instead of commit "\n" when pressing enter on virtual keyboard #1940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions app/src/main/java/com/osfans/trime/ime/core/TrimeInputMethodService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,21 +298,20 @@ open class TrimeInputMethodService : LifecycleInputMethodService() {

private fun handleReturnKey() {
currentInputEditorInfo.run {
if (inputType and InputType.TYPE_MASK_CLASS == InputType.TYPE_NULL) {
if (inputType and InputType.TYPE_MASK_CLASS == InputType.TYPE_NULL ||
imeOptions.hasFlag(EditorInfo.IME_FLAG_NO_ENTER_ACTION)
) {
sendDownUpKeyEvents(KeyEvent.KEYCODE_ENTER)
return
}
if (imeOptions.hasFlag(EditorInfo.IME_FLAG_NO_ENTER_ACTION)) {
val ic = currentInputConnection
ic?.commitText("\n", 1)
return
}
if (!actionLabel.isNullOrEmpty() && actionId != EditorInfo.IME_ACTION_UNSPECIFIED) {
currentInputConnection.performEditorAction(actionId)
return
}
when (val action = imeOptions and EditorInfo.IME_MASK_ACTION) {
EditorInfo.IME_ACTION_UNSPECIFIED, EditorInfo.IME_ACTION_NONE -> currentInputConnection.commitText("\n", 1)
EditorInfo.IME_ACTION_UNSPECIFIED,
EditorInfo.IME_ACTION_NONE,
-> sendDownUpKeyEvents(KeyEvent.KEYCODE_ENTER)
else -> currentInputConnection.performEditorAction(action)
}
}
Expand Down
Loading