fix(ratiorule): null sli spec validation

Signed-off-by: Hy3n4 <hy3nk4@gmail.com>
oskoperator · Nov 14, 2023 · 4cfae49 · 4cfae49
1 parent 4308f94
commit 4cfae49
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/internal/utils/common_utils.go b/internal/utils/common_utils.go
@@ -137,13 +137,19 @@ func (c RuleConfig) NewRatioRule(window string) (*monitoringv1.Rule, *monitoring
 
 	switch c.RuleType {
 	case "total":
+		if c.Sli.Spec.RatioMetric.Total.MetricSource.Spec == "" {
+			return nil, nil
+		}
 		expr = fmt.Sprintf("sum(increase(%s[%s]))", c.Sli.Spec.RatioMetric.Total.MetricSource.Spec, window)
 	case "bad":
 		if c.Sli.Spec.RatioMetric.Bad.MetricSource.Spec == "" {
 			return nil, nil
 		}
 		expr = fmt.Sprintf("sum(increase(%s[%s]))", c.Sli.Spec.RatioMetric.Bad.MetricSource.Spec, window)
 	case "good":
+		if c.Sli.Spec.RatioMetric.Good.MetricSource.Spec == "" {
+			return nil, nil
+		}
 		expr = fmt.Sprintf("sum(increase(%s[%s]))", c.Sli.Spec.RatioMetric.Good.MetricSource.Spec, window)
 	}