-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add release-drafter gh action #133
Conversation
CONTRIBUTING.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to include this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather not included it and just keep the simple rules that currently live in the README
https://github.com/oskoperator/osko?tab=readme-ov-file#contributing
Thank you for the PR! That's awesome. I've included some comments. |
3970c7b
to
50bf01b
Compare
Signed-off-by: Jose Santorum <jmsantorum@gmail.com>
I reviewed it! After simplifying a bit more the config I think now it is ready |
Thanks! Let's see what it will create in the main branch :D |
@jmsantorum looks really good the drafter, thanks for the contribution, we appreciate it! :) |
Signed-off-by: Jose Santorum <jmsantorum@gmail.com>
* feat(alerting): magic alerting hocus pocus Signed-off-by: Hy3n4 <hy3nk4@gmail.com> * feat(alert-severities): config like this? Signed-off-by: Robin Opletal <me@robinopletal.com> * fix(alert-severities): remove NoSlo severity Signed-off-by: Robin Opletal <me@robinopletal.com> * stylistic fixes Signed-off-by: Robin Opletal <me@robinopletal.com> * fix(config): nicer Cfg initialization Signed-off-by: Robin Opletal <me@robinopletal.com> * stop hardcoding 1-target in alertmanagerrule Signed-off-by: Robin Opletal <me@robinopletal.com> * feat(make): make wait for services better when deploying dev infratructure Signed-off-by: Hy3n4 <hy3nk4@gmail.com> * feat(alerting): alertmanager config loader edits (#130) * feat(alerting): alertmanager config loader Signed-off-by: Robin Opletal <me@robinopletal.com> * generated stuff... Signed-off-by: Robin Opletal <me@robinopletal.com> --------- Signed-off-by: Robin Opletal <me@robinopletal.com> * chore: add release-drafter gh action (#133) Signed-off-by: Jose Santorum <jmsantorum@gmail.com> * feat(magic): some features some fixes mainly fixed duration issues also, added some feature to devel, osko dashboards, kustomize for asier deployment and other cool stuff modified function responsible for creating the alerting rule when magiAlerting is enabled, also added some basic mapping for opsgenie, pagerduty and custom alerting tool. Currently not working as expected tho Signed-off-by: Hy3n4 <hy3nk4@gmail.com> * fix(rules): duplicated rules for 5m window Signed-off-by: Hy3n4 <hy3nk4@gmail.com> * prometheus helper: simplify unique windows, resolve finalizer API warnings Signed-off-by: Robin Opletal <me@robinopletal.com> * at least move uniqueStrings to function Signed-off-by: Robin Opletal <me@robinopletal.com> --------- Signed-off-by: Hy3n4 <hy3nk4@gmail.com> Signed-off-by: Robin Opletal <me@robinopletal.com> Signed-off-by: Jose Santorum <jmsantorum@gmail.com> Co-authored-by: Hy3n4 <hy3nk4@gmail.com> Co-authored-by: Jose Santorum <jmsantorum@gmail.com>
To improve the way releases are done, I want to start with the release content and fill it with the content of the PRs made since the last release.
For that, I'll use https://github.com/marketplace/actions/release-drafter action, and on the next PRs I'll try to fill a CONTRIBUTING.md document and at the same time I'll think about #131 in order to not only fill the release document, but also make a proper release (update project versions, and so on)
Related to #125