Skip to content

fix(project): adjust dev env README, fix crd kustomization #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2023
Merged

fix(project): adjust dev env README, fix crd kustomization #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,13 @@ See the [design document](DESIGN.md) for more details on what `osko` aims to do.
make install
```

3. Run your controller (this will run in the foreground, so switch to a new terminal if you want to leave it running):
3. We also depend on Prometheus Operator CRDs (`monitoring.coreos.com` API group). Let's install that to our local cluster now:

```sh
helm install prometheus-operator-crds prometheus-community/prometheus-operator-crds
```

4. Run your controller (this will run in the foreground, so switch to a new terminal if you want to leave it running):

```sh
make run
Expand Down
2 changes: 1 addition & 1 deletion config/crd/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ resources:
- bases/openslo.com_alertconditions.yaml
- bases/openslo.com_alertnotificationtargets.yaml
- bases/openslo.com_services.yaml
- bases/osko.openslo_mimirrules.yaml
- bases/osko.dev_mimirrules.yaml
#+kubebuilder:scaffold:crdkustomizeresource

patches: []
Expand Down