Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make red the default dataset visibility choice #226

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

simenheg
Copy link
Contributor

Also warn when a dataset is about to be registered as green (public).

@simenheg simenheg requested a review from a team June 14, 2024 06:58
@@ -62,9 +62,9 @@ def qs_create():
"name": "accessRights",
"message": "Tilgangsnivå",
"choices": [
Choice("Eksplisitt tilgangskontroll", "non-public"),
Choice("Origo", "restricted"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser kanskje ikke ut til at questionary enkelt støtter noen nærmere beskrivelse av disse valgene, men være et knepp mer eksplisitt i denne på hva den innebærer? F.eks. "Origo-ansatte", "Internt til Origo", "Til internt bruk (Origo)" (ikke at det nødvendigvis er helt presist heller) 🤔 (Dette, og flyten i stort, burde kanskje blitt sett på i samråd med designer etter hvert også.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nei, jeg så også etter det, det var synd. :/ "Internt til Origo" høres bra ut, endrer til det!

"Will create a new dataset '{}'.{}".format(
choices["title"],
(
"\n\nData uploaded to the dataset will be PUBLICLY AVAILABLE ON THE INTERNET.\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blir kanskje for mye å fargelegge litt her?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det skader vel ikke! Men kanskje det da kan gjøres i en egen PR hvor andre lignende advarsler også fargeleges. Kanskje fet skrift kunne holdt når jeg tenker meg om. 😛

Also warn when a dataset is about to be registered as green (public).
@simenheg simenheg merged commit 3c19718 into main Jun 14, 2024
8 checks passed
@simenheg simenheg deleted the red-by-default branch June 14, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants