remove linting rule and fix linting errors

oslokommune · Apr 19, 2024 · 6dead5e · 6dead5e
1 parent dfcb021
commit 6dead5e
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 17 deletions.
diff --git a/.stylelintrc.json b/.stylelintrc.json
@@ -6,7 +6,6 @@
       "preset": "bem"
     },
     "selector-class-pattern": null,
-    "no-descending-specificity": null,
-    "declaration-block-no-redundant-longhand-properties": null
+    "no-descending-specificity": null
   }
 }
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,11 +15,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 - Changed font-weight in video heading and refactored to correct scss setup.
-- Changed stylelint rules to exclude no-longhand-properties.
 - Updated package version for stylelint.
 
 ### Fixed
 
+- Fixed linting errors caused by new stylelint version.
+
 ### Removed
 
 - Removed twitter icon.

diff --git a/src/components/banner/banner.scss b/src/components/banner/banner.scss
@@ -20,11 +20,9 @@
     display: grid;
     grid-auto-flow: dense;
     grid-template-columns: repeat(#{grid.$columns}, 1fr);
-    column-gap: grid.$gutter-size;
-    row-gap: grid.$gutter-size;
+    gap: grid.$gutter-size;
     @include breakpoints.medium {
-      column-gap: grid.$gutter-size-large;
-      row-gap: grid.$gutter-size-large;
+      gap: grid.$gutter-size-large;
     }
 
     margin: 0 auto;

diff --git a/src/components/service_header/service_header.scss b/src/components/service_header/service_header.scss
@@ -30,9 +30,8 @@
   &__image {
     grid-row-start: 1;
     display: grid;
-    align-items: center;
     grid-column: 3 / 11;
-    justify-items: center;
+    place-items: center;
 
     img {
       max-width: 10.125rem;

diff --git a/src/general/grid/grid.scss b/src/general/grid/grid.scss
@@ -16,25 +16,21 @@
   }
 
   &--gap {
-    column-gap: grid.$gap-size-hard;
-    row-gap: grid.$gap-size-hard;
+    gap: grid.$gap-size-hard;
 
     @include breakpoints.medium {
-      column-gap: grid.$gap-size-hard-large;
-      row-gap: grid.$gap-size-hard-large;
+      gap: grid.$gap-size-hard-large;
     }
 
     &-breakpoint-medium {
       @include breakpoints.medium {
-        column-gap: grid.$gap-size-hard-large;
-        row-gap: grid.$gap-size-hard-large;
+        gap: grid.$gap-size-hard-large;
       }
     }
 
     &-breakpoint-large {
       @include breakpoints.large {
-        column-gap: grid.$gap-size-hard-large;
-        row-gap: grid.$gap-size-hard-large;
+        gap: grid.$gap-size-hard-large;
       }
     }
   }