Merge pull request #1034 from wmisener/wmisener/bookstore

Add Bookstores
osm-americana · Apr 1, 2024 · 3778eae · 3778eae
2 parents c378e98 + 38fc237
commit 3778eae
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 15 deletions.
diff --git a/icons/shield_us_az_scenic.svg b/icons/shield_us_az_scenic.svg
diff --git a/scripts/taginfo_template.json b/scripts/taginfo_template.json
@@ -687,6 +687,14 @@
       "doc_url": "https://openmaptiles.org/schema/#poi",
       "icon_url": "https://raw.githubusercontent.com/ZeLonewolf/openstreetmap-americana/main/icons/poi_pow_taoist.svg"
     },
+    {
+      "key": "shop",
+      "value": "books",
+      "object_types": ["node", "area"],
+      "description": "Bookstores are marked by an icon representing a book.",
+      "doc_url": "https://openmaptiles.org/schema/#poi",
+      "icon_url": "https://raw.githubusercontent.com/ZeLonewolf/openstreetmap-americana/main/icons/poi_book_upright.svg"
+    },
     {
       "key": "shop",
       "value": "car",

diff --git a/src/layer/poi.js b/src/layer/poi.js
@@ -19,6 +19,14 @@ var iconDefs = {
     color: Color.poi.consumer,
     description: "Bar or pub",
   },
+  bookstore: {
+    classes: {
+      library: ["books"],
+    },
+    sprite: "poi_book_upright",
+    color: Color.poi.consumer,
+    description: "Bookstore",
+  },
   bus_station: {
     classes: {
       bus: ["bus_station"],
@@ -313,6 +321,7 @@ export const poi = {
       [
         ...getSubclasses(iconDefs.fuel),
         ...getSubclasses(iconDefs.bar),
+        ...getSubclasses(iconDefs.bookstore),
         ...getSubclasses(iconDefs.coffee),
         ...getSubclasses(iconDefs.supermarket),
         ...getSubclasses(iconDefs.car_shop),
@@ -387,6 +396,7 @@ export const poi = {
       15,
       [
         ...getSubclasses(iconDefs.bar),
+        ...getSubclasses(iconDefs.bookstore),
         ...getSubclasses(iconDefs.coffee),
         ...getSubclasses(iconDefs.car_shop),
         ...getSubclasses(iconDefs.car_repair),

diff --git a/test/sample_locations.json b/test/sample_locations.json
@@ -49,7 +49,7 @@
     }
   },
   {
-    "location": "17/40.753326/-73.982224",
+    "location": "17/40.753922/-73.984244",
     "name": "library_z17",
     "viewport": {
       "width": 400,