Add icons for capitals of admin_level 5 and 6 #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claysmalley
commented
May 28, 2024
|
Overall PR looks good, but I'm seeing some minor artifacts on my display and wondering if we need to mess with the scaling a bit? I note that this icon is at a different scale than the state and national capital icons in the sprite sheet. See map example:
|
|
I made the whitespace slightly thicker in the icon. Does this look better on your screen?
|
|
Definite improvement here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #384
This PR refactors the capital symbology to apply to all values of
place=*(not justcity), and assigns places withcapital=5andcapital=6a new icon,place_dot_in_circle.