Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Pages URLs #1131

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Update GitHub Pages URLs #1131

merged 1 commit into from
Jul 19, 2024

Conversation

1ec5
Copy link
Member

@1ec5 1ec5 commented Jul 19, 2024

Replaced references to zelonewolf.github.io with americanamap.org. Although zelonewolf.github.io currently redirects to americanamap.org, Mapbox GL JS and MapLibre GL JS are apparently unable to follow the redirect due to a CORS error. This doesn’t affect the main deployed application, but it does affect anyone who uses the published style.json. Every fork of this repository will need to make a similar change.

@1ec5 1ec5 added the build label Jul 19, 2024
@1ec5 1ec5 self-assigned this Jul 19, 2024
@1ec5
Copy link
Member Author

1ec5 commented Jul 19, 2024

The following forks reference zelonewolf.github.io in generate-style.js, which causes them to break when loading style.json:

To fix this issue, you can either cherry-pick the changes here or manually replace https://zelonewolf.github.io/openstreetmap-americana with the URL to your own fork’s deployed site.

@1ec5 1ec5 merged commit fd81883 into main Jul 19, 2024
6 checks passed
@1ec5 1ec5 deleted the 1ec5-domain branch July 19, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants