Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easybox parcel locker: split HU & RO, fix operators, add tags #10131

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

gy-mate
Copy link
Contributor

@gy-mate gy-mate commented Nov 9, 2024

This PR fixes easybox parcel locker data.

  • Split HU & RO variants
  • Fix operators (Sameday is just a brand, not the actual operator)
  • Add tags to HU variant

@UKChris-osm
Copy link
Collaborator

Thanks @gy-mate

We generally don't include contact: or payment: tagging within the NSI however.

@gy-mate
Copy link
Contributor Author

gy-mate commented Nov 9, 2024

@UKChris-osm Thank you for the quick reaction!

We generally don't include contact: or payment: tagging within the NSI however.

I've removed them and added this info to the wiki.

@Dimitar5555
Copy link
Collaborator

I don't think that OSM likes having company types (EAD, Zrt, or S.A.) in operator fields (it may depend on the local community though). Also why does the Hungarian entry have operator:addr and company numbers tags? Is it common to place such tags there?

@gy-mate
Copy link
Contributor Author

gy-mate commented Nov 9, 2024

I don't think that OSM likes having company types (EAD, Zrt, or S.A.) in operator fields (it may depend on the local community though).

@Dimitar5555 The local community agrees on this, I've just asked them about it (1, 2). ref:HU:company=* and ref:HU:vatin=* is also tied to the company name and type.

Also why does the Hungarian entry have operator:addr and company numbers tags? Is it common to place such tags there?

Yes, it is. See operator:addr=*, ref:HU:company=* and ref:HU:vatin=* on Overpass Turbo.

@UKChris-osm
Copy link
Collaborator

I'd probably remove the operator:addr and ref tags as well from this index, as while it may seem handy having all these tags automatically added from within the NSI, I feel like it's out of scope for what we're trying to maintain, which is only really a canonical index of name / brand / operator.

It can also cause problems later on if an address or reference changes. If that information is available within the Wikidata article for each entry, then updating it there would make it available to those who need it.

@Snowysauce
Copy link
Collaborator

Apart from the discussion about payment:*, I agree with everything that's been said by the other maintainers. The operator:addr and ref:* tags are a maintenance nightmare waiting to happen, and they should be excluded from the NSI for the same reasons why we don't include contact:* tags.

In the case of payment:*, those tags have historically been allowed on a limited, case-by-case basis.

@Snowysauce Snowysauce added tagging fix data Need to cleanup the data in OSM after this is released needs discussion Waiting for other contributors to voice their opinion labels Nov 11, 2024
@UKChris-osm
Copy link
Collaborator

I hadn't realised payment: tagging was allowed in certain circumstances.

Personally I feel like that's an extra layer of maintenance we shouldn't be burdening ourselves with.

@bhousel
Copy link
Member

bhousel commented Nov 11, 2024

Oh yeah, my thought on this is that payment tags probably make sense for some limited kinds of POIs, like vending machines, or transit ticket machines, and it's probably fine for the parcel lockers too, and probably some other things I am not thinking about.

I mostly want to avoid something like people adding payment:cash=yes to every fast food brand world wide. While technically correct, it doesn't help anyone and would just be annoying and generate millions of tag upgrade warnings. There are a lot of tags on https://wiki.openstreetmap.org/wiki/Key:payment like this.

@UKChris-osm
Copy link
Collaborator

Oh yeah, my thought on this is that payment tags probably make sense for some limited kinds of POIs, like vending machines, or transit ticket machines, and it's probably fine for the parcel lockers too, and probably some other things I am not thinking about.

That makes sense regarding vending and ticket machines. I didn't actually think parcel lockers took payments directly though, I thought it was all done online or via an app?

@gy-mate
Copy link
Contributor Author

gy-mate commented Nov 11, 2024

I'd probably remove the operator:addr and ref tags as well from this index

@UKChris-osm @Snowysauce No problem, I've removed them! The wiki has been updated as well.

@gy-mate
Copy link
Contributor Author

gy-mate commented Nov 11, 2024

I didn't actually think parcel lockers took payments directly though, I thought it was all done online or via an app?

@UKChris-osm That's the case at Z-Boxes:

A red and white Packeta Z-BOX locker outdoors, surrounded by grass and trees. The locker is designed for parcel delivery and pickup.

But most other types of parcel lockers in Hungary do have a POS terminal:

A blue GLS package locker with multiple compartments and digital screens, prominently featuring the number 2500 and directional text. The locker is located indoors with bright overhead lighting.

A large locker system labeled "alzaBox" with promotional graphics on its doors. It features a black Garmin Venu 2 watch advertisement on the front. The locker has a green interactive screen and keypad on one section. There is graffiti on the wall to the left and a sign labeled "easybox" on the right.

A package locker system with a colorful design, featuring the Magyar Posta logo, a touchscreen interface, and illustrated maps with pinpoint markers. A woman holds a parcel on the left side of the image.

A red and blue eMAG easybox parcel locker is positioned on a sidewalk, featuring multiple compartments and a digital interface for package pickup. A car is visible in the background.

@DnaX
Copy link
Contributor

DnaX commented Nov 12, 2024

At least in Romania, Sameday it's the brand/name used by S.C. DELIVERY SOLUTIONS S.A..

Unfortunately it's very common to have a registered company with pointless name but nice marketing brand. Sameday it's the operator because Sameday it's how "S.C. DELIVERY SOLUTIONS S.A." it's known.

@UKChris-osm
Copy link
Collaborator

I'd suggest removing the operator tagging altogether and keeping it simple with just the brand tagging, as this is a part of the brand tree. While it might seem to make sense including operator, my view is "what if the operator changes, or the brand is sold, what if the brand expands via another operator in another country", etc.

@Snowysauce
Copy link
Collaborator

I agree with @UKChris-osm; given all the discussion above, I'd recommend:

  • dropping all of the operator tags from the preset
  • making a Wikidata item for the operator (if one doesn't exist) and placing all the name variations (and address) there
  • linking that page to the brand Wikidata page and vice versa (via the "operator"/"item operated" properties)

This way, the info in all its various forms is available from OSM to whoever wants it (via brand:wikidata and the links on its Wikidata page) without leading to prolonged discussions on OSM or here.

@DnaX
Copy link
Contributor

DnaX commented Nov 12, 2024

When i first created the preset, I added Sameday as operator just because some of those parcel lockers where sponsored by eMAG e-shop, so lots of people tagged as eMAG owned parcels (like Amazon Hubs).

BTW... ok to remove the operator tags.

@sammyhawkrad
Copy link
Contributor

"what if the operator changes, or the brand is sold, what if the brand expands via another operator in another country", etc.

Then the entries are updated here. Does this not happen sometimes?

@gy-mate
Copy link
Contributor Author

gy-mate commented Nov 16, 2024

In the case of payment:*, those tags have historically been allowed on a limited, case-by-case basis.

payment tags probably make sense for some limited kinds of POIs, like vending machines, or transit ticket machines, and it's probably fine for the parcel lockers too

I've put payment:*=* tags back in the list.

@gy-mate
Copy link
Contributor Author

gy-mate commented Nov 16, 2024

I'd recommend:

  • dropping all of the operator tags from the preset

@UKChris-osm @Snowysauce @DnaX Done...

  • making a Wikidata item for the operator (if one doesn't exist) and placing all the name variations (and address) there

...done:

  • linking that page to the brand Wikidata page and vice versa (via the "operator"/"item operated" properties)

...and done (I hope I've edited them correctly):

@gy-mate
Copy link
Contributor Author

gy-mate commented Nov 16, 2024

Then the entries are updated here. Does this not happen sometimes?

@sammyhawkrad I also support the idea of not duplicating things in order to make them easier to maintain.

@UKChris-osm
Copy link
Collaborator

As this has now become quite a long thread, can I just confirm the aim of this PR:

Currently, easybox is listed twice in the NSI, one for Bulgaria and one for Romania & Hungary, with both using the same Wikidata number.

The PR splits Romania & Hungary into a separate entry, so the NSI has 3 entries, all using the same Wikidata?

@CrowOk9830
Copy link

Fix operators (Sameday is just a brand, not the actual operator)

Sameday is a well known international courier service. Iit's a company group as stated on the about us page of their website.

In a survey, mappers will see Sameday on the parcel locker (the blue sticker shown previously is an older version; refer to pictures on the main page of their website or on their delivery vehicles), which clearly assigns some importance to that word. We should map what's on the ground mainly. (If Sameday is not the operator, what is that, how it should be tagged, or is it unimportant?)

On the other hand, the country-specific subsidiary company is not presented on the machine (except on the receipt maybe, if printed at all) and not a well known operator name. Thus changing operator to that feels some opinionated nitpicking, and ambiguity can lead to many edit wars.

The OSM wiki for Tag:amenity=parcel_locker also encourages using only the main operator name, such as operator=DPD, operator=DHL, operator=Amazon etc., not the local subsidiary with company type appended. Perhaps it`s worth discussing operator tagging practice more widely and doing changes in sync with OSM wiki.

From the point of view of NSI I can agree to keep operator=Sameday or remove it but not to change.

(Also note that Packate's Z-BOX is a similar case, where the brand of the parcel locker is Z-BOX, the operator is the Packeta courier service company group. I'm note sure brand=Packeta and name=Z-BOX is ok in terms of naming, because it applies the same name to every Packeta operated parcel locker (compared to the AlzaBox). Also see the OSM wiki about parcel locker names.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix data Need to cleanup the data in OSM after this is released needs discussion Waiting for other contributors to voice their opinion tagging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants