-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
easybox parcel locker: split HU & RO, fix operators, add tags #10131
base: main
Are you sure you want to change the base?
Conversation
Thanks @gy-mate We generally don't include |
@UKChris-osm Thank you for the quick reaction!
I've removed them and added this info to the wiki. |
I don't think that OSM likes having company types (EAD, Zrt, or S.A.) in operator fields (it may depend on the local community though). Also why does the Hungarian entry have |
@Dimitar5555 The local community agrees on this, I've just asked them about it (1, 2).
Yes, it is. See |
I'd probably remove the operator:addr and ref tags as well from this index, as while it may seem handy having all these tags automatically added from within the NSI, I feel like it's out of scope for what we're trying to maintain, which is only really a canonical index of name / brand / operator. It can also cause problems later on if an address or reference changes. If that information is available within the Wikidata article for each entry, then updating it there would make it available to those who need it. |
Apart from the discussion about In the case of |
I hadn't realised Personally I feel like that's an extra layer of maintenance we shouldn't be burdening ourselves with. |
Oh yeah, my thought on this is that I mostly want to avoid something like people adding |
That makes sense regarding vending and ticket machines. I didn't actually think parcel lockers took payments directly though, I thought it was all done online or via an app? |
@UKChris-osm @Snowysauce No problem, I've removed them! The wiki has been updated as well. |
@UKChris-osm That's the case at Z-Boxes: But most other types of parcel lockers in Hungary do have a POS terminal: |
At least in Romania, Sameday it's the brand/name used by S.C. DELIVERY SOLUTIONS S.A.. Unfortunately it's very common to have a registered company with pointless name but nice marketing brand. Sameday it's the operator because Sameday it's how "S.C. DELIVERY SOLUTIONS S.A." it's known. |
I'd suggest removing the |
I agree with @UKChris-osm; given all the discussion above, I'd recommend:
This way, the info in all its various forms is available from OSM to whoever wants it (via |
When i first created the preset, I added Sameday as operator just because some of those parcel lockers where sponsored by eMAG e-shop, so lots of people tagged as eMAG owned parcels (like Amazon Hubs). BTW... ok to remove the operator tags. |
Then the entries are updated here. Does this not happen sometimes? |
I've put |
@UKChris-osm @Snowysauce @DnaX Done...
...done:
...and done (I hope I've edited them correctly): |
@sammyhawkrad I also support the idea of not duplicating things in order to make them easier to maintain. |
As this has now become quite a long thread, can I just confirm the aim of this PR: Currently, easybox is listed twice in the NSI, one for Bulgaria and one for Romania & Hungary, with both using the same Wikidata number. The PR splits Romania & Hungary into a separate entry, so the NSI has 3 entries, all using the same Wikidata? |
Sameday is a well known international courier service. Iit's a company group as stated on the about us page of their website. In a survey, mappers will see Sameday on the parcel locker (the blue sticker shown previously is an older version; refer to pictures on the main page of their website or on their delivery vehicles), which clearly assigns some importance to that word. We should map what's on the ground mainly. (If Sameday is not the operator, what is that, how it should be tagged, or is it unimportant?) On the other hand, the country-specific subsidiary company is not presented on the machine (except on the receipt maybe, if printed at all) and not a well known operator name. Thus changing operator to that feels some opinionated nitpicking, and ambiguity can lead to many edit wars. The OSM wiki for Tag:amenity=parcel_locker also encourages using only the main operator name, such as From the point of view of NSI I can agree to keep operator=Sameday or remove it but not to change. (Also note that Packate's Z-BOX is a similar case, where the brand of the parcel locker is Z-BOX, the operator is the Packeta courier service company group. I'm note sure |
This PR fixes easybox parcel locker data.