-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bank.json with old_name for GCB Bank #9738
Conversation
Hi @sammyhawkrad , I think this would be better as a value of |
It's already added to the |
I wouldn't have thought this was needed, as that information is readily available via the wikidata item linked to it? It's not a tag we generally use within the Name Suggestion Index. |
I usually add it manually on OSM so that users can still find them with old name. If it doesn't fit with NSI, this PR can be discarded. |
This is a weird one. |
If |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there should be a better place for this data. But it's not the first old_name
in NSI. I have no major objection for it being here in the short term.
Yeah I'm pretty ok with this too. We usually use |
@sammyhawkrad would you be happy with using the |
Using alt_name would not be a true reflection of reality because it is their former name. |
If we decide to allow the old name to appear in the preset, according to the semantics of the key, it is obvious that Although this old name only works when used for matching and searching. I support keeping this tag, just like even if you mention 𝕏 today, you are more accustomed to using its old name, Twitter. |
No description provided.