Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bank.json with old_name for GCB Bank #9738

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

sammyhawkrad
Copy link
Contributor

No description provided.

@UKChris-osm
Copy link
Collaborator

Hi @sammyhawkrad , I think this would be better as a value of matchNames rather than using the tag old_name.

@sammyhawkrad
Copy link
Contributor Author

It's already added to the matchNames but I also want the old_name to be added.

@UKChris-osm
Copy link
Collaborator

I wouldn't have thought this was needed, as that information is readily available via the wikidata item linked to it? It's not a tag we generally use within the Name Suggestion Index.

@sammyhawkrad
Copy link
Contributor Author

I usually add it manually on OSM so that users can still find them with old name. If it doesn't fit with NSI, this PR can be discarded.

@Cj-Malone
Copy link
Collaborator

This is a weird one. old_name will massively help Nominatim and other search projects, but I don't think NSI is the place.

@UKChris-osm
Copy link
Collaborator

If old_name is helpful then it could be added, but would many people be searching for it on OSM via an old name in a year or two after a rebranding has taken place, would we not be adding data that's unnecessary in the long run?

Copy link
Collaborator

@Cj-Malone Cj-Malone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a better place for this data. But it's not the first old_name in NSI. I have no major objection for it being here in the short term.

@bhousel
Copy link
Member

bhousel commented Jul 23, 2024

Yeah I'm pretty ok with this too. We usually use alt_name for when a brand is in the process of switching names or uses both, but old_name is fine too if we think people might search for that.

@UKChris-osm
Copy link
Collaborator

@sammyhawkrad would you be happy with using the alt_name tag instead of old_name?

@sammyhawkrad
Copy link
Contributor Author

Using alt_name would not be a true reflection of reality because it is their former name.

@LaoshuBaby
Copy link
Collaborator

If we decide to allow the old name to appear in the preset, according to the semantics of the key, it is obvious that old_name is better than alt_name

Although this old name only works when used for matching and searching.

I support keeping this tag, just like even if you mention 𝕏 today, you are more accustomed to using its old name, Twitter.

@Cj-Malone Cj-Malone merged commit 75a1a09 into osmlab:main Sep 11, 2024
2 checks passed
loganrosen pushed a commit to loganrosen/name-suggestion-index that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants