Refine documentation of osmosis_powerline analyser #2591

flacombe · 2025-09-04T10:04:16Z

I propose the following improvements of classes documentation and add details for class 8

flacombe · 2025-09-04T10:30:01Z

I don't understand the tests results:

    def dump_class(self, classs):
        for id_ in classs:
            data = classs[id_]
            self.error_file.classs(
                id = id_,
>               item = data['item'],
                level = data['level'],
                tags = data.get('tags'),
                title = data.get('title'),
                detail = data.get('detail'),
                fix = data.get('fix'),
                trap = data.get('trap'),
                example = data.get('example'),
                source = data.get('source'),
                resource = data.get('resource'),
            )
E           TypeError: tuple indices must be integers or slices, not str

It's in Analyser_osmosis.py without change

analysers/analyser_osmosis_powerline.py

frodrigo · 2025-09-04T12:14:41Z

analysers/analyser_osmosis_powerline.py

+'''Suggested values may not be correct according to your knowledge, aerial imagery or survey.
+In such situations, power lines should be modified to better reflect how the power grid looks there.
+When doing so, you may wait for Osmose to update the suggestion or directly add the appropriate `line_management` value on the node.
+If you think power grid is right in OpenStreetMap, then mark this suggestion as false positive.'''))


That generic text, not specif to this case.

That's not generic to update ways to expect effect on a node I guess

Famlam

Some English suggestions

Famlam · 2025-09-07T08:24:56Z

analysers/analyser_osmosis_powerline.py

            trap = T_(
-'''It's possible that disused power features could be disconnected from the network.
-In which case make use of the `disused:` [lifecycle prefix](https://wiki.openstreetmap.org/wiki/Lifecycle_prefix).'''))
+'''It's possible that being built or disused power features could be disconnected from the live network.


Suggestion:

It is possible that power features under construction, or disused power features [...]

Famlam · 2025-09-07T08:26:41Z

analysers/analyser_osmosis_powerline.py

-'''It's possible that disused power features could be disconnected from the network.
-In which case make use of the `disused:` [lifecycle prefix](https://wiki.openstreetmap.org/wiki/Lifecycle_prefix).'''))
+'''It's possible that being built or disused power features could be disconnected from the live network.
+In which case make use of the `construction:` or `disused:` [lifecycle prefixes](https://wiki.openstreetmap.org/wiki/Lifecycle_prefix).'''))


Suggestion:

In this case the construction: or disused: lifecycle prefixes should be used.

Famlam · 2025-09-07T08:28:23Z

analysers/analyser_osmosis_powerline.py

+'''The line ends in a vacuum, and should be connected to another line or a substation (`power=substation`),
+a transformer (`power=transformer`), a generator (`power=generator`),
+marked as transitioning into ground (`line_management=transition + location:transition=yes`)
+or explicitely terminates (`line_management=termination`).'''),


Suggestion:

Terminated

Famlam · 2025-09-07T08:28:45Z

analysers/analyser_osmosis_powerline.py

            trap = T_(
-'''It's possible that disused power features could be disconnected from the network.
-In which case make use of the `disused:` [lifecycle prefix](https://wiki.openstreetmap.org/wiki/Lifecycle_prefix).'''))
+'''It's possible that being built or disused power features could be disconnected from the live network.


Same as above

Famlam · 2025-09-07T08:29:11Z

analysers/analyser_osmosis_powerline.py

+'''The line ends in a vacuum, and should be connected to another line or a substation (`power=substation`),
+a transformer (`power=transformer`), a generator (`power=generator`),
+marked as transitioning into ground (`line_management=transition + location:transition=yes`)
+or explicitely terminates (`line_management=termination`).'''),


Same as above

Famlam · 2025-09-07T08:31:46Z

analysers/analyser_osmosis_powerline.py

+            detail = T_(
+'''A line terminates near of a substation with inconsistent voltages between them.'''),
+            fix = T_(
+'''Continue the line towards its actual endpoint, check voltages on line and on substation and adjust what is required to better reflect what is seen on ground.''')),


[...] on the line and the substation and adjust what is necessary to reflect what is seen on the ground.

Famlam · 2025-09-07T08:33:06Z

analysers/analyser_osmosis_powerline.py

-
+            title = T_('Power support line management suggestion'),
+            detail = T_(
+'''[line_management](https://wiki.openstreetmap.org/wiki/Key:line_management) documents particular topologies occuring on power lines nodes. Mind looking at values documentation.


The last sentence seems incorrect to me, do you mean " Have a look at the documented values"?

Famlam · 2025-09-07T08:33:22Z

analysers/analyser_osmosis_powerline.py

+            title = T_('Power support line management suggestion'),
+            detail = T_(
+'''[line_management](https://wiki.openstreetmap.org/wiki/Key:line_management) documents particular topologies occuring on power lines nodes. Mind looking at values documentation.
+Suggestions are computed by looking at existing OpenStreetMap power lines and only supports some combinations.


Famlam · 2025-09-07T08:33:53Z

analysers/analyser_osmosis_powerline.py

+            detail = T_(
+'''[line_management](https://wiki.openstreetmap.org/wiki/Key:line_management) documents particular topologies occuring on power lines nodes. Mind looking at values documentation.
+Suggestions are computed by looking at existing OpenStreetMap power lines and only supports some combinations.
+It's an encouragement to check and confirm the structure of the power grid on most relevant towers, particularly when proposed `line_management` differs from existing value.


It's encouraged

Famlam · 2025-09-07T08:34:46Z

analysers/analyser_osmosis_powerline.py

+'''[line_management](https://wiki.openstreetmap.org/wiki/Key:line_management) documents particular topologies occuring on power lines nodes. Mind looking at values documentation.
+Suggestions are computed by looking at existing OpenStreetMap power lines and only supports some combinations.
+It's an encouragement to check and confirm the structure of the power grid on most relevant towers, particularly when proposed `line_management` differs from existing value.
+Proposed values are to be adopted when conform to ground according to your knowledge, aerial imagery or survey.'''),


Not sure what this means?
Unless it's a generic "tagging should confirm to ground truth"-statement (in which case it's unnecessary)

Refine documentation of osmosis_powerline analyser

45d5f76

flacombe mentioned this pull request Sep 4, 2025

Area flooded with “Power support line management suggestion” warnings #2548

Closed

frodrigo reviewed Sep 4, 2025

View reviewed changes

analysers/analyser_osmosis_powerline.py Outdated Show resolved Hide resolved

frodrigo reviewed Sep 4, 2025

View reviewed changes

Remove source code reference

2ee7910

Famlam reviewed Sep 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refine documentation of osmosis_powerline analyser #2591

Refine documentation of osmosis_powerline analyser #2591

Uh oh!

flacombe commented Sep 4, 2025

Uh oh!

flacombe commented Sep 4, 2025

Uh oh!

Uh oh!

frodrigo Sep 4, 2025

Uh oh!

flacombe Sep 4, 2025

Uh oh!

Famlam left a comment

Uh oh!

Famlam Sep 7, 2025

Uh oh!

Famlam Sep 7, 2025

Uh oh!

Famlam Sep 7, 2025

Uh oh!

Famlam Sep 7, 2025

Uh oh!

Famlam Sep 7, 2025

Uh oh!

Famlam Sep 7, 2025

Uh oh!

Famlam Sep 7, 2025

Uh oh!

Famlam Sep 7, 2025

Uh oh!

Famlam Sep 7, 2025

Uh oh!

Famlam Sep 7, 2025

Uh oh!

Uh oh!

Refine documentation of osmosis_powerline analyser #2591

Are you sure you want to change the base?

Refine documentation of osmosis_powerline analyser #2591

Uh oh!

Conversation

flacombe commented Sep 4, 2025

Uh oh!

flacombe commented Sep 4, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Famlam left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!