perf(state/store): avoid double-saving ABCI responses #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czarcas7ic
commented
Feb 27, 2024
Comment on lines
+439
to
+442
| if height != info.GetHeight() { | ||
| return nil, fmt.Errorf("expected height %d but last stored abci responses was at height %d", height, info.GetHeight()) | ||
| } | ||
| return info.AbciResponses, nil |
There was a problem hiding this comment.
I left out the following logic branch because I don't think it matters here, but would like an ACK
if info.FinalizeBlock == nil {
// sanity check
if info.LegacyAbciResponses == nil {
panic("state store contains last abci response but it is empty")
}
return responseFinalizeBlockFromLegacy(info.LegacyAbciResponses), nil
}
There was a problem hiding this comment.
This is for an edge case, but I think this backports it wrong
There was a problem hiding this comment.
I will hold off on merging this till we talk next then
There was a problem hiding this comment.
oh your right we are fine without this logic branch, sorry about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments