Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport CS lock removal #137

Merged
merged 4 commits into from
Aug 19, 2024
Merged

backport CS lock removal #137

merged 4 commits into from
Aug 19, 2024

Commits on Aug 19, 2024

  1. perf(consensus): Undo revert cometbft#3211. (Remove reactor Consensus…

    … RLocks) (backport cometbft#3341) (cometbft#3490)
    
    Pretty simple bug fix for the e2e failure on cometbft#3211. There was a race
    condition at iniitialization for initial height, because we didn't
    initialize it early on enough.
    
    The error in the E2E logs was:
    ```
    validator03    | E[2024-06-21|21:13:20.744] Stopping peer for error                      module=p2p peer="Peer{MConn{10.186.73.2:34810} 4fe295e4cfad69f1247ad85975c6fd87757195db in}" err="invalid field LastCommitRound can only be negative for initial height 0"
    validator03    | I[2024-06-21|21:13:20.744] service stop                                 module=p2p peer=4fe295e4cfad69f1247ad85975c6fd87757195db@10.186.73.2:34810 msg="Stopping Peer service" impl="Peer{MConn{10.186.73.2:34810} 4fe295e4cfad69f1247ad85975c6fd87757195db in}"
    ```
    hinting at initial height not being set rpoperly.
    
    ---
    
    - [ ] Tests written/updated
    - [ ] Changelog entry added in `.changelog` (we use
    [unclog](https://github.com/informalsystems/unclog) to manage our
    changelog)
    - [ ] Updated relevant documentation (`docs/` or `spec/`) and code
    comments
    - [ ] Title follows the [Conventional
    Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
    <hr>This is an automatic backport of pull request cometbft#3341 done by
    [Mergify](https://mergify.com).
    
    Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
    mergify[bot] and ValarDragon committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    601c002 View commit details
    Browse the repository at this point in the history
  2. BP 3156

    ValarDragon committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    195d6fb View commit details
    Browse the repository at this point in the history
  3. use rsMtx

    ValarDragon committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5bf7ef6 View commit details
    Browse the repository at this point in the history
  4. Fix lint

    ValarDragon committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9355856 View commit details
    Browse the repository at this point in the history