Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(event bus): Remove expensive Logger debug call in PublishEventTx… (backport #38) #44

Merged
merged 1 commit into from
May 2, 2024

Commits on May 2, 2024

  1. perf(event bus): Remove expensive Logger debug call in PublishEventTx…

    … (backport cometbft#2911) (cometbft#2937) (#38)
    
    Component of cometbft#2869
    
    This on its own is an expected 1% speedup to blocksync on osmosis
    mainnet right now.
    
    I originally considered keeping the log lines but with only creating the
    logger cost if there is an error, but these are debug logs I've never
    seen. I think its better to just remove these debug logs directly,
    rather than worry about maintaining them. These aren't even that
    concerning scenarios I feel like, as more of the stack moves away from
    these.
    
    ---
    
    #### PR checklist
    
    - [x] Tests written/updated - Covered by existing tests
    - [x] Changelog entry added in `.changelog` (we use
    [unclog](https://github.com/informalsystems/unclog) to manage our
    changelog)
    - [X] Updated relevant documentation (`docs/` or `spec/`) and code
    comments
    - [X] Title follows the [Conventional
    Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
    <hr>This is an automatic backport of pull request cometbft#2911 done by
    [Mergify](https://mergify.com).
    
    ---------
    
    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
    Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
    Co-authored-by: Andy Nogueira <me@andynogueira.dev>
    (cherry picked from commit a9991fd)
    czarcas7ic authored and mergify[bot] committed May 2, 2024
    Configuration menu
    Copy the full SHA
    7427a0b View commit details
    Browse the repository at this point in the history