Skip to content

CI Implementation #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 17, 2024
Merged

CI Implementation #45

merged 16 commits into from
Jul 17, 2024

Conversation

BT-Creator
Copy link
Collaborator

@BT-Creator BT-Creator commented Jul 16, 2024

What's done

A CI implementation that checks the following items:

  • Controller
    -- [X] Does it build?
  • Loama
    -- [X] Is Eslint checking correct?
    -- [X] Does the application build?
    -- [X] Is the Typescript conversion done without any problems

Need to know

  • GH actions uses Node V18, which is the highest version available. So you'll see in the input that the engine is unsupported
  • The results are piped to the job summary, but it's not really formatted (except for the ESLint-Markdown version)

@BT-Creator BT-Creator linked an issue Jul 16, 2024 that may be closed by this pull request
4 tasks
@BT-Creator BT-Creator marked this pull request as ready for review July 16, 2024 14:18
@BT-Creator BT-Creator changed the title CI / CD Implementation CI Implementation Jul 17, 2024
@BT-Creator BT-Creator requested review from Zelzahn, elroyK and Vicba July 17, 2024 08:26
Copy link

@elroyK elroyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I think if it was wrong it would break anyway haha

@BT-Creator BT-Creator merged commit e5a81d0 into root Jul 17, 2024
2 of 4 checks passed
@Zelzahn Zelzahn deleted the 43-ci-cd-fix-github-actions branch July 22, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ CI & CD ] Fix Github Actions
4 participants