Fix timing tests by using ranges #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've noticed several failures on these tests. Generally, I think it's because GitHub Actions is on shared CPUs and prone to randomly pausing. This, in turn, makes the timing tests very squirrely This is an attempt at converting from expected counts, to range checks I don't love it, and it's not going to catch all failures, but I'm not sure there's a better approach
directionless
changed the title
RebeccaMahany
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed several failures on these tests. Generally, I think it's because GitHub Actions is on shared CPUs and prone to randomly pausing. This, in turn, makes the timing tests very squirrely
This is an attempt at converting from expected counts, to range checks I don't love it, and it's not going to catch all failures, but I'm not sure there's a better approach