Set internal version for OpenTelemetry traces on initialization #114
Conversation
| ) | ||
|
|
||
| func TestTraceInit(t *testing.T) { | ||
| t.Parallel() |
There was a problem hiding this comment.
Test looks good, though t.Parallel has no effect on this test. It is useful when used with t.Run().
There was a problem hiding this comment.
t.Parallel() can have an effect without t.Run() -- by default, all tests within a package run sequentially rather than in parallel, and the call to t.Parallel() here would change that behavior if/when any other test cases are added to this package.
It doesn't look like we're consistent with t.Parallel() in this repo -- some tests use it, others don't. I like it as a default, so I would be inclined to keep it here unless you feel strongly about it?
There was a problem hiding this comment.
Ya, no worries, I agree. I meant to say that given there's only one test on this package, t.Parallel won't make a difference, but moving forward if we stick to using it then, yes.
When I pulled in #110 to began using traces, I noticed that it was possible to have a data race when the first few spans created by a consuming application could be created at the same time. This PR fixes that issue and adds a test to confirm the fix as well.