Leftover penny issue FIX #466
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/tests/addStore.test.ts
Collaborator
|
After an initial glance, I have 3 major comments. Please take the time to set up the necessary tooling: prettier+oxc as clearly the formatting is broken. Second of all, the leftover pennies can also occur with percentage and share types which is not covered by this PR. Finally, I created a PR template for a reason, please use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #402 where settled balances would break after minor edits
Changes:
Example:
Before: Split $0.04 three ways → edit description → pennies reshuffled
Now: Split $0.04 three ways → edit description → pennies stay the same
(Btw, Sorry for my previous incorrectly written PR with this issue)