Add locale-aware date formatting for UI dates #471
+32
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krokosik
requested changes
Nov 5, 2025
Comment on lines
+41
to
+44
| return format(date, 'MMM dd', { | ||
| locale: getSupportedLanguages().find((lang) => lang.code === todayTranslation.usedLng) | ||
| ?.dateLocale, | ||
| }); |
Collaborator
There was a problem hiding this comment.
I suppose we could just use new Intl.DateTimeFormat(todayTranslation.usedLng, {day: '2-digit', month: 'short'}).format(date)?
Contributor
Author
There was a problem hiding this comment.
I tried that, but this Intl API is kind of weird. At least for pt-BR and pt-PT, the results are awful, so I'm not sure what other languages would look like to native speakers.
pt-PT:
I don't know why it would format "short" month to "11" (we have "numeric" for that, right?).
pt-BR:
The word "de" here is just a preposition that we can totally ignore when we want it to be shorter.
Maybe we could have a specific function only for this expense date prefix and use the Intl for other places, which would probably make this look better:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds locale-aware dates, fixes #470.
Demo
Checklist
CONTRIBUTING.mdin its entirety