Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ort.yml parsing snippet report generation for SCANOSS #10004

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

isasmendiagus
Copy link

SCANOSS snippet report generation

  • Implement snippet choice functionality for SCANOSS integration
  • Add support for processing exclude paths from ort.yml configuration
  • Add dedicated SCANOSS snippet report

@sschuberth
Copy link
Member

@isasmendiagus, please rebase your PR onto latest main and resolve conflicts with a recent code change to make the PR checks start.

@isasmendiagus isasmendiagus force-pushed the feat/scanoss/parse-ort-yml-file-on-scanoss-integration-cherry-pick branch from 29719d8 to aa42ab6 Compare March 5, 2025 15:04
@isasmendiagus
Copy link
Author

@isasmendiagus, please rebase your PR onto latest main and resolve conflicts with a recent code change to make the PR checks start.

Hi @sschuberth, done with the conflicts

@sschuberth sschuberth changed the title feat(scanoss-plugin): implement ort.yml configuration parsing & add SCANOSS snippet report generation Implement ort.yml parsing snippet report generation for SCANOSS Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.58%. Comparing base (9d6a7e8) to head (83e5bed).
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10004      +/-   ##
============================================
+ Coverage     68.77%   69.58%   +0.80%     
- Complexity     1432     1462      +30     
============================================
  Files           267      270       +3     
  Lines          9394     9665     +271     
  Branches        999     1025      +26     
============================================
+ Hits           6461     6725     +264     
- Misses         2487     2489       +2     
- Partials        446      451       +5     
Flag Coverage Δ
funTest-docker 63.95% <ø> (-0.41%) ⬇️
funTest-non-docker 33.29% <ø> (ø)
test-ubuntu-24.04 39.34% <ø> (+1.65%) ⬆️
test-windows-2022 39.31% <ø> (+1.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sschuberth
Copy link
Member

@isasmendiagus, please have a look at the various failed checks.

@isasmendiagus isasmendiagus force-pushed the feat/scanoss/parse-ort-yml-file-on-scanoss-integration-cherry-pick branch from aa42ab6 to 5f67f5c Compare March 7, 2025 08:17
@isasmendiagus isasmendiagus force-pushed the feat/scanoss/parse-ort-yml-file-on-scanoss-integration-cherry-pick branch from 5f67f5c to e45cf6e Compare March 7, 2025 12:33
@sschuberth
Copy link
Member

@isasmendiagus, please remove the merge commit from the PR's history. Also, if you expected to get reviews, please mark the draft as "Ready for review" 😉

@isasmendiagus isasmendiagus force-pushed the feat/scanoss/parse-ort-yml-file-on-scanoss-integration-cherry-pick branch from 7e6ed63 to e45cf6e Compare March 12, 2025 07:18
@isasmendiagus isasmendiagus marked this pull request as ready for review March 12, 2025 07:19
@isasmendiagus isasmendiagus requested a review from a team as a code owner March 12, 2025 07:19
@isasmendiagus isasmendiagus marked this pull request as draft March 12, 2025 09:11
@isasmendiagus isasmendiagus force-pushed the feat/scanoss/parse-ort-yml-file-on-scanoss-integration-cherry-pick branch 2 times, most recently from 96b8a8f to 27566cb Compare March 12, 2025 13:55
Replace custom direct API calls to SCANOSS with the official Java SDK.
This change improves maintainability by leveraging the SDK's functionality
instead of maintaining custom implementation for API interactions.

Signed-off-by: Agustin Isasmendi <agustin.isasmendi@scanoss.com>
@isasmendiagus isasmendiagus force-pushed the feat/scanoss/parse-ort-yml-file-on-scanoss-integration-cherry-pick branch from 27566cb to 83e5bed Compare March 12, 2025 14:00
Implement a custom filter in the scanPath method that integrates with the
ScanOSS SDK to properly handle file exclusions based on patterns. The filter
converts paths appropriately to work with the context's exclude patterns.

Signed-off-by: Agustin Isasmendi <agustin.isasmendi@scanoss.com>
@isasmendiagus isasmendiagus force-pushed the feat/scanoss/parse-ort-yml-file-on-scanoss-integration-cherry-pick branch 2 times, most recently from b27ae1c to 05bfef5 Compare March 12, 2025 21:20
Implement snippet choice processing functionality.
It handles findings according to two different scenarios:
- Original findings that should be included
- Non-relevant findings that should be removed

The implementation converts ORT's SnippetChoices
into SCANOSS-specific rule types

Signed-off-by: Agustin Isasmendi <agustin.isasmendi@scanoss.com>
Implement functionality to generate snippet findings reports from
SCANOSS scan results.

Signed-off-by: Agustin Isasmendi <agustin.isasmendi@scanoss.com>
Include releaseDate in snippetFindings additionalData and add a new
column to display this information in generated reports.

Signed-off-by: Agustin Isasmendi <agustin.isasmendi@scanoss.com>
* Generate multiple snippetFindings for each detected line range
* Remove duplicate licenses to optimize results
* Remove identified snippets from the summary

Signed-off-by: Agustin Isasmendi <agustin.isasmendi@scanoss.com>
@isasmendiagus isasmendiagus force-pushed the feat/scanoss/parse-ort-yml-file-on-scanoss-integration-cherry-pick branch from 7f3895b to e36f5ec Compare March 12, 2025 22:59
@isasmendiagus isasmendiagus marked this pull request as ready for review March 12, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants