Explain where and how tool configuration is (de-)serialized #10447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
force-pushed
the
model-de-ser-docs
branch
3 times, most recently
from
086c4bb to
bf65c23
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10447 +/- ##
============================================
- Coverage 56.74% 56.73% -0.01%
+ Complexity 1642 1640 -2
============================================
Files 337 337
Lines 12476 12475 -1
Branches 1177 1177
============================================
- Hits 7079 7078 -1
Misses 4945 4945
Partials 452 452
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Note that these docs delibertely omit the pathological case in the `ConfigCommand`, which uses Jackson to serialize `OrtConfiguration` to a YAML string via Jackson as Hoplite does not support serialization at all. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Besides the now ignorable exception in the `ConfigCommand`, `ReporterConfiguration` is never (de-)serialized via Jackson, so the annotation can be removed for simplicity. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
It was added 1.5 years ago, so just remove it. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
sschuberth
force-pushed
the
model-de-ser-docs
branch
from
3d43b66 to
7610768
Compare
mnonnenmacher
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.