-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(schema): Fix the JSON schema for the repository configuration #9847
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9847 +/- ##
============================================
+ Coverage 68.12% 68.37% +0.25%
- Complexity 1293 1328 +35
============================================
Files 250 250
Lines 8843 8918 +75
Branches 918 935 +17
============================================
+ Hits 6024 6098 +74
+ Misses 2432 2431 -1
- Partials 387 389 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f6a1b04
to
cdb4c94
Compare
integrations/schemas/repository-configurations/analyzer-configuration-schema.json
Show resolved
Hide resolved
analyzer: | ||
package_managers: | ||
Gradle: | ||
must_run_after: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to double-check: In my global config.yml
I use mustRunAfter
and it works. And that's exactly the (confusing) point, that the syntax is different between config.yml
and .ort.yml
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests now also cover the two cases:
allow_dynamic_versions
in the added analyzer-repository-configuration.ort.yml
file,
and allowDynamicVersions
in the reference.yml
file.
By reusing the analyzer configuration schema, the properties incorrectly used camel-case notation, change it to snake-case. While at it, remove the `Sw360Configuration` from the schema, which is not part of the analyzer configuration model. Resolves #7680. Signed-off-by: Marcel Bochtler <git@bochtler.io>
Signed-off-by: Marcel Bochtler <git@bochtler.io>
cdb4c94
to
8dbd425
Compare
By reusing the analyzer configuration schema, the properties incorrectly used camel case notation, change it to snake case.
While at it, remove the
Sw360Configuration
from the schema, which is not part of the analyzer configuration model.Resolves #7680