feat(black-duck): Make the log output show how the origin is determined #9850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
black-duck-log-enhancement
branch
from
7ed9925 to
ecbbe96
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9850 +/- ##
=========================================
Coverage 68.12% 68.12%
Complexity 1293 1293
=========================================
Files 250 250
Lines 8843 8843
Branches 918 918
=========================================
Hits 6024 6024
Misses 2432 2432
Partials 387 387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
reviewed
Jan 28, 2025
| @@ -158,10 +158,10 @@ class BlackDuck( | |||
| } | |||
|
|
|||
| if (origins.isEmpty()) { | |||
| logger.info { "No origin found for package '${pkg.id.toCoordinates()}'." } | |||
| logger.info { "No origin found for package '${pkg.id.toCoordinates()}', ${pkg.requestParam}." } | |||
There was a problem hiding this comment.
I find it a bit unusual to use a comma here, as it's not an enumeration, but an alternative way to refer to the same package. So maybe use parentheses as in (${pkg.requestParam}) instead?
There was a problem hiding this comment.
Did you forget to push this change?
fviernau
force-pushed
the
black-duck-log-enhancement
branch
from
ecbbe96 to
30e8b26
Compare
Log the query parameter (purl or origin-id) to make obvious how the origin is of each respective package is determined. Signed-off-by: Frank Viernau <x9fviern@zeiss.com>
fviernau
force-pushed
the
black-duck-log-enhancement
branch
from
30e8b26 to
4bc4ac6
Compare
sschuberth
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log the query parameter (purl or origin-id) to make obvious how the origin is of each respective package is determined.
Part of: #8739.