advisors/black-duck: CVSS2 parsing fixes #9855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
black-duck-cvss2-parsing-fixes
branch
from
3d7382b to
b23f029
Compare
fviernau
force-pushed
the
black-duck-cvss2-parsing-fixes
branch
2 times, most recently
from
6123743 to
e665687
Compare
Signed-off-by: Frank Viernau <x9fviern@zeiss.com>
fviernau
force-pushed
the
black-duck-cvss2-parsing-fixes
branch
from
e665687 to
691caa4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sschuberth
requested changes
Jan 29, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9855 +/- ##
=========================================
Coverage 68.12% 68.12%
Complexity 1292 1292
=========================================
Files 250 250
Lines 8840 8840
Branches 917 917
=========================================
Hits 6022 6022
Misses 2431 2431
Partials 387 387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
force-pushed
the
black-duck-cvss2-parsing-fixes
branch
from
691caa4 to
ec9bdc1
Compare
Signed-off-by: Frank Viernau <x9fviern@zeiss.com>
Avoid recomputing the values and reduce the nesting level. Signed-off-by: Frank Viernau <x9fviern@zeiss.com>
Signed-off-by: Frank Viernau <x9fviern@zeiss.com>
This illustrates an issue with parsing the `vector` and `scoring_system`. Signed-off-by: Frank Viernau <x9fviern@zeiss.com>
fviernau
force-pushed
the
black-duck-cvss2-parsing-fixes
branch
from
ec9bdc1 to
59bb47d
Compare
sschuberth
reviewed
Jan 29, 2025
| @@ -220,6 +224,18 @@ internal fun VulnerabilityView.toOrtVulnerability(): Vulnerability { | |||
| ) | |||
| } | |||
|
|
|||
| private fun VulnerabilityCvss3View.getScoringSystemAndVector(): Pair<String, String> { | |||
| val scoringSystem = vector.substringBefore('/', "").ifEmpty { Cvss3Rating.PREFIXES.first() } | |||
|
|
|||
There was a problem hiding this comment.
Consider dropping this empty line now to visually align with the function below.
The resulting `vector` parsed from a given CVSS2 data structure
accidentally kept surrounding braces. Furthermore, extracting the
`scoringSystem` via `substringBefore('/')` gave wrong results, because
a CVSS2 vector does not have such a scoring system prefix at all, but
contains slashes, see also the diff in `CVE-2015-3996-parsed.yml`.
Signed-off-by: Frank Viernau <x9fviern@zeiss.com>
fviernau
force-pushed
the
black-duck-cvss2-parsing-fixes
branch
from
59bb47d to
9898a44
Compare
sschuberth
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Part of: #8739.