Re-order middleware to allow /healthz

Signed-off-by: Brett Logan <lindluni@github.com>

index.js

@@ -13,6 +13,7 @@ import {
 } from './src/middleware.js'
 
 const app = express()
+app.get('/healthz', respond)
 app.use(express.json())
 app.use(debugRequest)
 app.use(hydrateKey)
@@ -23,9 +24,6 @@ app.use(verifyGitHubWebhook)
 app.use(verifyMembership)
 app.use(verifyCommand)
 app.use(hydrateOctokit)
-
-app.get('/', respond)
-app.get('/healthz', respond)
 app.post('/api/github/webhooks', processWebhook)
 
 const main = async () => {

src/middleware.js

@@ -96,7 +96,10 @@ export const hydrateOctokit = async (req, res, next) => {
 }
 
 export const verifyMembership = async (req, res, next) => {
-    if (req.body.comment.author_association === 'MEMBER') {
+    if (req.body.comment.author_association === 'COLLABORATOR' ||
+        req.body.comment.author_association === 'MEMBER' ||
+        req.body.comment.author_association === 'CONTRIBUTOR' ||
+        req.body.comment.author_association === 'OWNER') {
         return next()
     }
     return next('User is not a member')

src/utils.js

@@ -7,4 +7,14 @@ export const retrieveRequiredChecks = async (properties) => {
         }
     }
     return requiredChecks
+}
+
+export const unless = function (path, middleware) {
+    return function (req, res, next) {
+        if (path === req.path) {
+            return next();
+        } else {
+            return middleware(req, res, next);
+        }
+    };
 }