Create pagination for the index page #198 #201
Conversation
apps/web/controllers/tasks/index.rb
Outdated
| @@ -29,5 +31,9 @@ def with_language(search_params) | |||
| def status | |||
| Task::VALID_STATUSES.values.include?(params[:status]) ? params[:status] : 'in progress' | |||
| end | |||
|
|
|||
| def limit | |||
| 10 | |||
apps/web/controllers/tasks/index.rb
Outdated
| expose :tasks | ||
|
|
||
| def call(params) | ||
| @tasks = TaskRepository.new.find_by(search_params) | ||
| repo = TaskRepository.new.find_by(search_params) | ||
| @tasks = all_for_page(repo) |
There was a problem hiding this comment.
it's not a repo 🤔
let's rename it to relation
apps/web/views/tasks/index.rb
Outdated
| @@ -76,5 +77,85 @@ def author_information(author, task) | |||
| text(" • #{task.lang}") | |||
| end | |||
| end | |||
|
|
|||
| def pagination | |||
| html.div(class: 'pagination') do | |||
There was a problem hiding this comment.
we really need all this code without any specs here?
There was a problem hiding this comment.
I wrote this code, because pagination function was not available in hanami-pagination gem.
Now i replaced it with gem function.
| @@ -29,7 +29,7 @@ def all_from_date_counted_by_status_and_day(from) | |||
| end | |||
|
|
|||
| def find_by(params = {}) | |||
| tasks.where(params).order { id.desc }.map_to(Task).to_a | |||
| tasks.where(params).order { id.desc }.map_to(Task) | |||
There was a problem hiding this comment.
WDYT if we split this code into two methods:
def find_by(params = {})
search_relation(params).to_a
end
def search_relation(params)
tasks.where(params).order { id.desc }.map_to(Task)
end| end | ||
|
|
||
| it 'returns 10 tasks on page' do | ||
|
|
| @@ -155,6 +155,41 @@ | |||
| expect(action.tasks.map(&:status)).to all(eq('in progress')) | |||
| end | |||
| end | |||
|
|
|||
| context 'when are on the first page' do | |||
There was a problem hiding this comment.
let's simplify specs here. For this we can use DI (dependency injection and wiki) for repository instance:
So, I found a problem in pagination davydovanton/hanami-pagination#10, thanks for this! 💯 🌟 🎉
|
|
||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
could you cut unnecessary spaces here and format specs? thanks!
There was a problem hiding this comment.
Ok, i will focus on it more.
|
Hi. |
Hello.
Nice issue for newby web programmers like me.