FSF40 Hackathon day 3: presentation overhaul #47
Conversation
|
@arthurhb-math, i test it and i will left you comments. |
|
@arthurhb-math, it looks like your change is not working. 
|
|
Oh, my bad. It was a very simple error, it should be fixed with this latest commit. |
| {% endfor %} | ||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
@arthurhb-math, please don't remove this dropdown.
If possible update the design.
There was a problem hiding this comment.
@arthurhb-math, you can remove it. Not useful anymore.
i prefer the remote link.
lewa/static/core/css/style.css
Outdated
| font-weight: normal; | ||
| font-style: normal; | ||
| font-display: swap; | ||
| } |
There was a problem hiding this comment.
@arthurhb-math, in the base template, the font is added on the html header.
can you update in using a remote font?
a font not stored in the source code.
There was a problem hiding this comment.
@arthurhb-math, this image is too heavy, can you compress it?
|
@arthurhb-math, the UI is looking better and better. Thanks for your contributions. When you will apply the changes, i will be happy to merge it. |
|
@pythonbrad Thanks! I will make the changes as soon as possible. |
pythonbrad
added
the
fsf-hackathon
|
@arthurhb-math, thanks again for your contributions. Is it this PR ok to be merged? |
|
@pythonbrad Sure, I won't really have as much time today as the other days, so this is my last contribution for the hackathon. Just quote me when you feel it's time to fix lint (#37 ) after the hackathon is over. I would like to keep helping the project, if it's fine with you. Happy hacking! |
|
@arthurhb-math, the pr is merged, feel free to proceed with the code formating. |
ghost
deleted the
1 participant
I made some changes regarding presentation (graphical/textual), based on #33.
I gave the UI some polish, and fixed some minor deviations from standard English in the text.
I'll let the results speak for themselves:
Thanks a lot for this hackathon! I learned a lot. I look forward to continuing to contribute to this project.
And of course, if there are any issues with this PR, let me know.