Skip to content

Conversation

@mzihlmann
Copy link
Collaborator

Fixes # in case of a bug fix, this should point to a bug and any other related issue(s)

Description

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

@mzihlmann
Copy link
Collaborator Author

and my assumption is correct, there are a handful of integration tests that clearly dominate runtime

[
  {
    "file": "integration/benchmarks/Dockerfile_test_issue_cg73",
    "time": "19.679570495s"
  },
  {
    "file": "integration/benchmarks/Dockerfile_test_issue_2066",
    "time": "21.811286056s"
  },
  {
    "file": "integration/benchmarks/Dockerfile_test_issue_2049",
    "time": "23.87137586s"
  },
  {
    "file": "integration/benchmarks/Dockerfile_test_issue_684",
    "time": "30.058323824s"
  },
  {
    "file": "integration/benchmarks/Dockerfile_test_issue_1039",
    "time": "69.829787105s"
  }
]

let's try to rewrite them with synthetic tests to bring that runtime down.

@mzihlmann
Copy link
Collaborator Author

mzihlmann commented Aug 24, 2025

interesting, the integration test was not even complete, so it never even tested for the regression, instead manual action was needed after the build. now it's complete and failure cause can be reproduced with it in the affected images

docker run --network=host -v $(pwd):/workspace gcr.io/kaniko-project/executor:v0.17.1   --dockerfile /workspace/integration/dockerfiles/Dockerfile_test_issue_1039 --context dir:///workspace/ --no-push --force
...
INFO[0069] Unpacking rootfs as cmd RUN echo test requires it. 
error building image: error building stage: failed to get filesystem from image: removing whiteout .wh.dev: unlinkat //dev/pts/ptmx: operation not permitted

@mzihlmann mzihlmann force-pushed the benchmarks branch 5 times, most recently from fcb54cd to 9b6a330 Compare August 25, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants