-
-
Notifications
You must be signed in to change notification settings - Fork 13
106 landlock #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mzihlmann
wants to merge
3
commits into
main
Choose a base branch
from
106-landlock
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
106 landlock #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By redirecting all RUN commands via this wrapper-binary we have an entrypoint to voluntarily drop permissions. If we would drop permissions in the main kaniko process they would be gone for good. By adding a wrapper we automatically regain permissions after RUN finished.
Collaborator
Author
|
The problem is that landlock doesn't like rename and I can't teach apt to not use it: |
076f2ca to
10ed865
Compare
10ed865 to
0e167d3
Compare
Collaborator
Author
|
looks like blacklisting is already in their pipeline landlock-lsm/linux#28 |
Collaborator
Author
|
hmmm looks like creating a wrapper thread is actually enough landlock-lsm/linux#2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Experimental branch to play around with landlock, at the moment it is working as expected but not really usable as it breaks in most real world dockerfiles.
The goal is to restrict malicious
RUNstatements from accessing/kanikodirectory, where we currently store registry-credentials and other secrets.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.