Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Parse function to pkgecosystem, use in ResolvePackage #769

Merged
merged 3 commits into from
Jun 20, 2023
Merged

add Parse function to pkgecosystem, use in ResolvePackage #769

merged 3 commits into from
Jun 20, 2023

Conversation

maxfisher-g
Copy link
Contributor

Add a Parse function to the pkgecosystem enum, as discussed in #663. This simplifies the code in ResolvePackage.

Also add a function to return a formatted ErrUnsupported for unrecognised ecosystem names.

@maxfisher-g
add Parse function to pkgecosystem, and use in downloader tool
73474a1 
Signed-off-by: Max Fisher <maxfisher@google.com>
maxfisher-g and others added 2 commits June 20, 2023 16:00
@maxfisher-g
Merge branch 'main' into pkgecosystem_parse
3a12198
@maxfisher-g
fix purl parsing issue
8fb549a 
Signed-off-by: Max Fisher <maxfisher@google.com>
@maxfisher-g maxfisher-g requested a review from oliverchang June 20, 2023 06:13
@maxfisher-g maxfisher-g merged commit 461099e into main Jun 20, 2023
@maxfisher-g maxfisher-g deleted the pkgecosystem_parse branch June 20, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverchang oliverchang oliverchang approved these changes

@calebbrown calebbrown Awaiting requested review from calebbrown

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxfisher-g @oliverchang