Propose adding a tentative addition #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
|
I do tentative additions and find them helpful, especially for discovering unnecessary indirect dependencies. I suggest others do the same. Thoughts? |
|
@SecurityCRob - maybe this could proposal could be mentioned in a BEST WG meeting? I think voting for approval seems like the cleanest way to add a whole new proposed item. |
lehors
reviewed
Oct 6, 2023
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
As noted in [CommonMark list-items](https://spec.commonmark.org/0.30/#list-items), "The most important thing to notice is that the position of the text after the list marker determines how much indentation is needed in subsequent blocks in the list item. If the list marker takes up two spaces of indentation, and there are three spaces between the list marker and the next character other than a space or tab, then blocks must be indented five spaces in order to fall under the list item." This means that renumbering an item may require indentation changes to match. Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
|
Note: the only real addition is a new point 9. The old point 9 is renumbered to point 10. Markdown lists must align to the text after the number, so the sub-bullets must all get 1 extra space at the beginning. So this change looks larger than it really is. |
|
+1 looks good! |
balteravishay
approved these changes
Nov 21, 2023
torgo
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.