Modify rationale for separate debug info #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current text *way* oversells the value of separate debug info. Depending on separating debug info for security is a terrible idea. Decompilers and similar tools work quite well even when debug info is separate. Also, many of the readers are thinking about open source software, and clearly trying to hide the source code when it's public doesn't make any sense (!). So I suggest emphasizing the *size* argument (which is uncontroversial), then briefly noting the other argument but emphasizing that hiding debug info doesn't really prevent decompilation. If you want to hide secrets, omitting debug info is a *terrible* way to do it :-). Let's not claim otherwise. Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
thomasnyman
approved these changes
Nov 8, 2023
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current text way oversells the value of separate debug info. Depending on separating debug info for security is a terrible idea. Decompilers and similar tools work quite well even when debug info is separate. Also, many of the readers are thinking about open source software, and clearly trying to hide the source code when it's public doesn't make any sense (!).
So I suggest emphasizing the size argument (which is uncontroversial), then briefly noting the other argument but emphasizing that hiding debug info doesn't really prevent decompilation.
If you want to hide secrets, omitting debug info is a terrible way to do it :-). Let's not claim otherwise.