Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pySCG: Adding documentation to CWE-175 as part of #531 #687

Merged
merged 26 commits into from
Nov 28, 2024
Merged

pySCG: Adding documentation to CWE-175 as part of #531 #687

merged 26 commits into from
Nov 28, 2024

Conversation

s19110
Copy link
Contributor

@s19110 s19110 commented Oct 31, 2024

Adding documentation to CWE-175 as part of #531

@s19110
Adding documentation to CWE-175 as part of ossf#531
9a71d3f 
Signed-off-by: edanhub <hubert.daniszewski@ericsson.com>
@myteron myteron self-requested a review November 2, 2024 12:54
@gkunz gkunz requested a review from BartyBoi1128 November 4, 2024 16:43
myteron
myteron reviewed Nov 6, 2024
View reviewed changes
docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/compliant01.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code not working, line 12 and 15 are missing locale.CURRENT_LOCALE

docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/README.md Outdated Show resolved Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/compliant03.py Outdated Show resolved Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/noncompliant03.py Outdated Show resolved Hide resolved
@myteron myteron changed the title Adding documentation to CWE-175 as part of #531 pySCG: Adding documentation to CWE-175 as part of #531 Nov 6, 2024
@s19110
CWE-175 - changing code examples and adding locale install note
d52639f 
Signed-off-by: edanhub <hubert.daniszewski@ericsson.com>
s19110 and others added 2 commits November 21, 2024 12:11
@s19110 @myteron
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/README.md
0663387 
Co-authored-by: myteron <myteron@gmail.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110 @myteron
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/example03.py
438d4ad 
Co-authored-by: myteron <myteron@gmail.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
BartyBoi1128
BartyBoi1128 suggested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@BartyBoi1128 BartyBoi1128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments with suggestions, In "example03.py" I couldn't leave a suggested change on all the lines but essentially just wondering can we remove one "#" from the comments, just leave it at "#" rather than "##"

s19110 and others added 6 commits November 21, 2024 12:52
@s19110 @BartyBoi1128
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/README.md
961370b 
Co-authored-by: BartyBoi1128 <58297160+BartyBoi1128@users.noreply.github.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110 @BartyBoi1128
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/compliant0…
595a172 
…1.py

Co-authored-by: BartyBoi1128 <58297160+BartyBoi1128@users.noreply.github.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110 @BartyBoi1128
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/compliant0…
89f1bc7 
…2.py

Co-authored-by: BartyBoi1128 <58297160+BartyBoi1128@users.noreply.github.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110 @BartyBoi1128
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/example03.py
ae79d31 
Co-authored-by: BartyBoi1128 <58297160+BartyBoi1128@users.noreply.github.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110 @BartyBoi1128
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/example03.py
5a87704 
Co-authored-by: BartyBoi1128 <58297160+BartyBoi1128@users.noreply.github.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110 @BartyBoi1128
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/noncomplia…
13eb097 
…nt01.py

Co-authored-by: BartyBoi1128 <58297160+BartyBoi1128@users.noreply.github.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
s19110 and others added 3 commits November 21, 2024 12:56
@s19110 @BartyBoi1128
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/noncomplia…
fc01ae1 
…nt01.py

Co-authored-by: BartyBoi1128 <58297160+BartyBoi1128@users.noreply.github.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110 @BartyBoi1128
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/noncomplia…
2ae69c5 
…nt02.py

Co-authored-by: BartyBoi1128 <58297160+BartyBoi1128@users.noreply.github.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110 @BartyBoi1128
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/noncomplia…
95a905d 
…nt01.py

Co-authored-by: BartyBoi1128 <58297160+BartyBoi1128@users.noreply.github.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110
Copy link
Contributor Author

s19110 commented Nov 21, 2024

Left comments with suggestions, In "example03.py" I couldn't leave a suggested change on all the lines but essentially just wondering can we remove one "#" from the comments, just leave it at "#" rather than "##"

Thank you for the suggestions, I have now merged all of them. As for the "##" in comments, I will change them to a singular "#" and indicate if they are supposed to be console output or something else.

s19110 and others added 2 commits November 21, 2024 13:54
@s19110
Fixed linter errors for CWE-175
25d1ccf 
Signed-off-by: edanhub <hubert.daniszewski@ericsson.com>
@s19110
Merge branch 'main' into pyCode2GitHub_CWE-175
9de7604 
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
myteron
myteron requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@myteron myteron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example01.py code does not work. Rest is more or less cosmetic hope I got matching code between .py and .md

docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/README.md Outdated Show resolved Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/example01.py Outdated Show resolved Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/README.md Outdated Show resolved Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/example03.py Outdated Show resolved Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/README.md Outdated Show resolved Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/README.md Outdated Show resolved Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/README.md Outdated Show resolved Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/compliant02.py Outdated Show resolved Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/noncompliant02.py Outdated Show resolved Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/README.md Outdated Show resolved Hide resolved
s19110 and others added 11 commits November 28, 2024 09:30
@s19110 @myteron
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/README.md
5216713 
Co-authored-by: myteron <myteron@gmail.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110 @myteron
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/README.md
9fde368 
Co-authored-by: myteron <myteron@gmail.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110 @myteron
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/example01.py
acea30e 
Co-authored-by: myteron <myteron@gmail.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110 @myteron
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/README.md
283aefa 
Co-authored-by: myteron <myteron@gmail.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110 @myteron
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/example03.py
d331fe9 
Co-authored-by: myteron <myteron@gmail.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110 @myteron
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/README.md
78cb8cc 
Co-authored-by: myteron <myteron@gmail.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110 @myteron
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/README.md
5f78b13 
Co-authored-by: myteron <myteron@gmail.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110 @myteron
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/README.md
0ded86a 
Co-authored-by: myteron <myteron@gmail.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110 @myteron
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/compliant0…
5a5df3e 
…2.py

Co-authored-by: myteron <myteron@gmail.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110 @myteron
Update docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/noncomplia…
45033c8 
…nt02.py

Co-authored-by: myteron <myteron@gmail.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
@s19110
Updated code examples in README for CWE-175
7d9d2e8 
Signed-off-by: edanhub <hubert.daniszewski@ericsson.com>
myteron
myteron approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@myteron myteron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working

docs/Secure-Coding-Guide-for-Python/CWE-707/CWE-175/README.md Show resolved Hide resolved
@myteron myteron merged commit 437708f into ossf:main Nov 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BartyBoi1128 BartyBoi1128 BartyBoi1128 approved these changes

@myteron myteron myteron approved these changes

Assignees
No one assigned
Labels
Product: Python Hardening Guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s19110 @myteron @BartyBoi1128