Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for differences between website and designs #28

Open
alexdor opened this issue Sep 27, 2018 · 11 comments
Open

Search for differences between website and designs #28

alexdor opened this issue Sep 27, 2018 · 11 comments
Labels
good first issue Good for newcomers

Comments

@alexdor
Copy link
Member

alexdor commented Sep 27, 2018

Design images can be found here

@alexdor alexdor added the good first issue Good for newcomers label Sep 27, 2018
@Timileyin5
Copy link

Can you elaborate on what needs to be done here?

@alexdor
Copy link
Member Author

alexdor commented Sep 27, 2018

@Timileyin5 you are right, the description is a bit vague. The final website needs to be checked for inconsistencies with the original designs.

Does this make more sense?

@Timileyin5
Copy link

How do I know which image I should be checking with? for example for the homepage there's A, B, and C. How do I decide the right one to check against?

@alexdor
Copy link
Member Author

alexdor commented Sep 27, 2018

A,B,C are all different states of the homepage, for example in A the "I do my magic in" part is empty, in B the user has selected a few languages and in C the user has selected a few languages and a few more options.

So you all of them are the right one : )

@Timileyin5
Copy link

okay, that makes sense. Thank you for explaining!

@dbarochiya
Copy link

@alexdor In screenshots of the design footer contains various links to connect like email, GitHub but it is not reflected in the code let me know if I can move ahead to fix this.

@alexdor
Copy link
Member Author

alexdor commented Oct 11, 2018

@bacharakis do we have all the links so we can add them to the footer?

@Jay341997
Copy link

@alexdor In image Mozilla_Fixme_Screen02_Issues.png there is a select button for sort by. so can you tell me what types are there for sort by?

@alexdor
Copy link
Member Author

alexdor commented Oct 15, 2018

I'm not sure what sorting types should be included to be honest, for sure the issue date (ascending or descending) is going to be on of them. @bacharakis any other order by filters?

@bacharakis
Copy link
Contributor

Thank you all for your comments!
For the link, we can have the following:
GitHub: github.com/ossn/fixme
Twitter: http://twitter.com/fixmeparser
Instead of legal we should have: Participation Guidelines: https://www.mozilla.org/en-US/about/governance/policies/participation/

In terms of @Jay341997 question about sorting, the only option for now should be by date.

@Muljayan
Copy link
Contributor

White line on the right side of the learn more button

image

Browser : Google chrome 69.0.3497.100 (Official Build) (64-bit)
O/S: Ubuntu 18.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants